-
Notifications
You must be signed in to change notification settings - Fork 1.2k
createSassMigrator method to wrap common functionality #7499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ea0194
to
1903e87
Compare
jesstelford
commented
Oct 25, 2022
1903e87
to
419b52e
Compare
jesstelford
commented
Oct 25, 2022
jesstelford
commented
Oct 25, 2022
polaris-migrator/src/migrations/replace-spacing-lengths/replace-spacing-lengths.ts
Show resolved
Hide resolved
419b52e
to
7886de6
Compare
This was referenced Oct 26, 2022
7886de6
to
e9271e4
Compare
sam-b-rose
approved these changes
Oct 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this is very simple an what I was imagining our Stylelint rule wrapper would look like 👍
e9271e4
to
f711b74
Compare
f711b74
to
3723b68
Compare
Merged
laurkim
pushed a commit
that referenced
this pull request
Oct 28, 2022
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-migrator@0.7.0 ### Minor Changes - [#7499](#7499) [`85c0c3290`](85c0c32) Thanks [@jesstelford](https://github.com/jesstelford)! - Add `createSassMigrator` utility to stash common logic, starting with only parsing each event once. - [#7541](#7541) [`141746b5b`](141746b) Thanks [@jesstelford](https://github.com/jesstelford)! - Internally setup stylelint metadata for SASS migrations in preparation for switching to stylelint as our migration runner. ## @shopify/plugin-polaris@0.0.15 ### Patch Changes - Updated dependencies \[[`85c0c3290`](85c0c32), [`141746b5b`](141746b)]: - @shopify/polaris-migrator@0.7.0 ## @shopify/polaris@10.10.1 ### Patch Changes - [#7561](#7561) [`fc78fcc48`](fc78fcc) Thanks [@kyledurand](https://github.com/kyledurand)! - Fix typo in box property, remove PropsWithChildren ## polaris-for-figma@0.0.28 ### Patch Changes - Updated dependencies \[[`fc78fcc48`](fc78fcc)]: - @shopify/polaris@10.10.1 ## polaris.shopify.com@0.23.3 ### Patch Changes - Updated dependencies \[[`fc78fcc48`](fc78fcc)]: - @shopify/polaris@10.10.1 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR belongs to a series of proposed changes:
NOTE: This PR is best viewed with whitespace changes hidden
The
createSassMigrator
utility helps encapsulate two patterns that are common across all our migrators:postcss
Best visualized as a diff of what a migration might look like: