Rename z-index tokens
#7607
Closed
Rename z-index tokens
#7607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 tasks
size-limit report 📦
|
…ename-z-index-tokens
alex-page
approved these changes
Nov 18, 2022
|
@lgriffee I have unblocked this PR with conflicts in the base branch. I have a suggestion. I think we should create these new tokens in version 10 (while keeping the old ones around). Run the migrations in version 10 to remove the old token usage. Then in version 11 we will remove the old tokens. This will make it easier to ship version 11 as we don't have to wait for it to ship the update to the tokens. Let me know what you think? |
|
Going to close this PR in favor of #8245 (kicks off what @alex-page mentioned above) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #7587
WHAT is this pull request doing?
Change the naming of our z-index tokens from
--p-z-*to--p-z-index-*to improve clarity.