SASS migration for animation: declarations #7611
Conversation
|
/snapit |
|
🫰✨ Thanks @jesstelford! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/plugin-polaris@0.0.0-snapshot-release-20221102054907yarn add @shopify/polaris-migrator@0.0.0-snapshot-release-20221102054907 |
jesstelford
force-pushed
the
migrate-motion
branch
4 times, most recently
from
b5d8db5 to
3876095
Compare
jesstelford
force-pushed
the
migrate-animatable
branch
2 times, most recently
from
a423198 to
3c28678
Compare
|
|
||
| if (isKeyOf(easingFuncHandlers, node.value)) { | ||
| easingFuncHandlers[node.value](node, decl); | ||
| if (ignoreUnknownFunctions) { |
There was a problem hiding this comment.
Discovered a bug where transition-timing-function: nonsense was not flagged as an error. This flag (and surrounding logic catches it).
jesstelford
force-pushed
the
migrate-animatable
branch
from
3c28678 to
e5a271d
Compare
|
/snapit |
|
🫰✨ Thanks @jesstelford! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/plugin-polaris@0.0.0-snapshot-release-20221103032324yarn add @shopify/polaris-icons@0.0.0-snapshot-release-20221103032324yarn add @shopify/polaris-migrator@0.0.0-snapshot-release-20221103032324yarn add @shopify/polaris@0.0.0-snapshot-release-20221103032324yarn add @shopify/stylelint-polaris@0.0.0-snapshot-release-20221103032324 |
jesstelford
force-pushed
the
migrate-animatable
branch
from
e5a271d to
9ac1859
Compare
|
/snapit |
jesstelford
force-pushed
the
migrate-animatable
branch
from
9ac1859 to
73b440c
Compare
|
/snapit |
|
🫰✨ Thanks @jesstelford! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/plugin-polaris@0.0.0-snapshot-release-20221103041932yarn add @shopify/polaris-icons@0.0.0-snapshot-release-20221103041932yarn add @shopify/polaris-migrator@0.0.0-snapshot-release-20221103041932yarn add @shopify/polaris@0.0.0-snapshot-release-20221103041932yarn add @shopify/stylelint-polaris@0.0.0-snapshot-release-20221103041932 |
There was a problem hiding this comment.
Nice work incorporating animation declarations. I made a lot of revisions in the renaming PR (#7606) and can take over merging this into the new structure 🎉 📁 🗄️ thanks @jesstelford 🙏
### WHY are these changes introduced? Incorporates work from #7611 into current motion migration. ### WHAT is this pull request doing? Add the `animation`, `animation-duration`, `animation-delay`, `animation-timing-function` properties to the `styles-tokenize-motion` migration.
|
Going to close out this PR for now. The |
Basically just #7403, but with added support for
animate:(and non-shorthand variants).After diving down a rabbit hole of trying to parse
animate:declarations, I realised the parts we care about are identical to thetransition:ones I've already done, and the changes were minimal to add support 🎉Also added flags for turning on/off the transition/animation handlers (plus tests).