Skip to content

[DataTable] Update DataTable summary row implementation to support columnContentTypes #7693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 10, 2022
Merged

[DataTable] Update DataTable summary row implementation to support columnContentTypes #7693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
253f778
Update `DataTable` to properly inherit `columnTypes` in summary rows
philschoefer Nov 10, 2022
3a07a29
Adds changeset
philschoefer Nov 10, 2022
1238069
Combined destructuring in `DataTable` and updated changeset copy
philschoefer Nov 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/brave-ways-carry.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/polaris': patch
---

Fixed a bug where `DataTable` summary row would not properly inherit type defined in `columnContentTypes` prop
4 changes: 2 additions & 2 deletions polaris-react/src/components/DataTable/DataTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -852,7 +852,7 @@ class DataTableInner extends PureComponent<CombinedProps, DataTableState> {
}) => {
const fixedFirstColumns = this.fixedFirstColumns();
const id = `totals-cell-${index}`;
const {truncate = false, verticalAlign} = this.props;
const {truncate = false, verticalAlign, columnContentTypes} = this.props;

let content;
let contentType;
Expand All @@ -862,7 +862,7 @@ class DataTableInner extends PureComponent<CombinedProps, DataTableState> {
}

if (total !== '' && index > 0) {
contentType = 'numeric';
contentType = columnContentTypes[index];
content = total;
}

Expand Down