Skip to content

[Bleed] Remove spacing prop #7732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 17, 2022
Merged

[Bleed] Remove spacing prop #7732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5cf9b14
[Bleed] Remove spacing prop
kyledurand Nov 16, 2022
da45476
update props
kyledurand Nov 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/tricky-apes-vanish.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@shopify/polaris': patch
'polaris.shopify.com': patch
---

Removed `spacing` prop from Bleed component
2 changes: 1 addition & 1 deletion polaris-react/src/components/Bleed/Bleed.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ export function WithSpecificDirection() {
export function WithAllDirection() {
return (
<Box background="surface" padding="4">
<Bleed spacing="6">
<Bleed horizontal="6" vertical="6">
<div style={styles} />
</Bleed>
</Box>
Expand Down
5 changes: 0 additions & 5 deletions polaris-react/src/components/Bleed/Bleed.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@ import styles from './Bleed.scss';
export interface BleedProps {
/** Elements to display inside tile */
children: React.ReactNode;
/** Negative space around the element */
spacing?: SpacingSpaceScale;
/** Negative horizontal space around the element
* * @default '5'
*/
Expand All @@ -27,7 +25,6 @@ export interface BleedProps {
}

export const Bleed = ({
spacing,
horizontal = '5',
vertical,
top,
Expand Down Expand Up @@ -55,8 +52,6 @@ export const Bleed = ({
return directionValues.horizontal;
} else if (!xAxis.includes(direction) && vertical) {
return directionValues.vertical;
} else {
return spacing;
}
};

Expand Down
2 changes: 1 addition & 1 deletion polaris-react/src/components/Bleed/tests/Bleed.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ describe('<Bleed />', () => {

it('renders custom properties combined with any overrides if they are passed in', () => {
const bleed = mountWithApp(
<Bleed spacing="1" left="2" horizontal="3">
<Bleed vertical="1" left="2" horizontal="3">
<Children />
</Bleed>,
);
Expand Down
2 changes: 1 addition & 1 deletion polaris.shopify.com/pages/examples/bleed-all-directions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {withPolarisExample} from '../../src/components/PolarisExampleWrapper';
function BleedAllDirectionsExample() {
return (
<Box background="surface" border="base" padding="4">
<Bleed spacing="4">
<Bleed vertical="4" horizontal="4">
<Placeholder label="All directions" />
</Bleed>
</Box>
Expand Down
Loading