Skip to content

Fix TextStyle migration to use fontWeight="semibold" instead of fontWeight="bold" #7744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 17, 2022
Merged

Fix TextStyle migration to use fontWeight="semibold" instead of fontWeight="bold" #7744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7705d69
[polaris.shopify.com] Fix TextStyle mapping for `variation="strong"`
laurkim Nov 17, 2022
39c2636
Fix migration to replace TextStyle `variation="strong"` with `fontWei…
laurkim Nov 17, 2022
edb179a
Add changeset
laurkim Nov 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/tiny-ravens-sing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@shopify/polaris-migrator': patch
'polaris.shopify.com': patch
---

Fixed mapping for `TextStyle` `variation="strong"` to use `Text` `fontWeight="semibold"` instead of `fontWeight="bold"`
2 changes: 1 addition & 1 deletion polaris-migrator/src/migrations/react-replace-text-components/steps/replace-text-style.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import type {MigrationOptions} from '../react-replace-text-components';
import {POLARIS_MIGRATOR_COMMENT} from '../../../constants';

const variationMap = {
strong: {fontWeight: 'bold'},
strong: {fontWeight: 'semibold'},
subdued: {color: 'subdued'},
positive: {color: 'success'},
negative: {color: 'critical'},
Expand Down
2 changes: 1 addition & 1 deletion ...c/migrations/react-replace-text-components/tests/react-replace-text-components.output.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export function App() {
<Text variant="bodySm" as="p">
Caption
</Text>
<Text variant="bodyMd" fontWeight="bold" as="span">
<Text variant="bodyMd" fontWeight="semibold" as="span">
Strong
</Text>
<Text variant="bodyMd" color="success" as="span">
Expand Down
2 changes: 1 addition & 1 deletion polaris-migrator/src/migrations/react-replace-text-components/tests/with-relative.output.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export function App() {
<Text variant="bodySm" as="p">
Caption
</Text>
<Text variant="bodyMd" fontWeight="bold" as="span">
<Text variant="bodyMd" fontWeight="semibold" as="span">
Strong
</Text>
<Text variant="bodyMd" color="success" as="span">
Expand Down
2 changes: 1 addition & 1 deletion polaris.shopify.com/content/components/text-style.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ status:

```diff
- <TextStyle variation="strong">No supplier listed</TextStyle>
+ <Text variant="bodyMd" as="span" fontWeight="bold">No supplier listed</Text>
+ <Text variant="bodyMd" as="span" fontWeight="semibold">No supplier listed</Text>
```

### Positive
Expand Down