Skip to content

[Layout] Add ul support to Box #7803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 25, 2022
Merged

[Layout] Add ul support to Box #7803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
629f64e
Add `ul` to elements supported by `Box`
aveline Nov 25, 2022
2ab13e2
Update props.json
aveline Nov 25, 2022
1694bc1
changeset
aveline Nov 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/happy-llamas-doubt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@shopify/polaris': minor
'polaris.shopify.com': patch
---

Added support for `ul` element on `Box`
8 changes: 8 additions & 0 deletions polaris-react/src/components/Box/Box.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,3 +112,11 @@
.visuallyHidden {
@include visually-hidden;
}

.listReset {
list-style-type: none;
margin-block-start: 0;
margin-block-end: 0;
outline: none;
padding-inline-start: 0;
}
3 changes: 2 additions & 1 deletion polaris-react/src/components/Box/Box.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import {

import styles from './Box.scss';

type Element = 'div' | 'span' | 'section';
type Element = 'div' | 'span' | 'section' | 'ul';
type Overflow = 'hidden' | 'scroll';
type Position = 'relative' | 'absolute' | 'fixed' | 'sticky';

Expand Down Expand Up @@ -321,6 +321,7 @@ export const Box = forwardRef<HTMLElement, BoxProps>(
const className = classNames(
styles.Box,
visuallyHidden && styles.visuallyHidden,
as === 'ul' && styles.listReset,
);

return createElement(
Expand Down
Loading