Skip to content

Update OptionList role types #7962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Update OptionList role types #7962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e532551
Remove `string` from `role` types
aveline Dec 21, 2022
ae23c3f
Update props.json
aveline Dec 21, 2022
4053e9a
changeset
aveline Dec 21, 2022
d4295f5
Merge branch 'v11-major' into option-list-role-types
aveline Dec 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/witty-files-grab.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/polaris': major
---

Removed `string` from `role` types for `OptionList` component
2 changes: 1 addition & 1 deletion polaris-react/src/components/OptionList/OptionList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export interface OptionListProps {
/** Collection of options to be listed */
options?: OptionDescriptor[];
/** Defines a specific role attribute for the list itself */
role?: 'listbox' | 'combobox' | string;
role?: 'listbox' | 'combobox';
/** Defines a specific role attribute for each option in the list */
optionRole?: string;
/** Sections containing a header and related options */
Expand Down
Loading