This repository was archived by the owner on Sep 30, 2025. It is now read-only.
Add outline style prop to Box
#7992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
|
Anymore context you can add here? I can see it's used on the wrapper |
|
Yes good question. I don't think it has anything to do with |
kyledurand
approved these changes
Jan 6, 2023
Merged
kyledurand
pushed a commit
that referenced
this pull request
Jan 6, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris@10.18.0 ### Minor Changes - [#7992](#7992) [`e8f74f4cd`](e8f74f4) Thanks [@aveline](https://github.com/aveline)! - Added support for `outline` to `Box` ### Patch Changes - [#7988](#7988) [`382784f4e`](382784f) Thanks [@kyledurand](https://github.com/kyledurand)! - Reduced spacing on ChoiceList children - [#7899](#7899) [`930f077eb`](930f077) Thanks [@jeradg](https://github.com/jeradg)! - Fixed a bug where Tooltips nested in Scrollable containers sometimes don't update their positions correctly - [#7831](#7831) [`47487ee0c`](47487ee) Thanks [@acmertz](https://github.com/acmertz)! - Updated the focus helper functions to no longer treat buttons with `aria-disabled="true"` and `tabindex="-1" (but no`disabled\` attribute) as focusable. ## @shopify/plugin-polaris@0.0.25 ## polaris.shopify.com@0.28.2 ### Patch Changes - Updated dependencies \[[`382784f4e`](382784f), [`930f077eb`](930f077), [`47487ee0c`](47487ee), [`e8f74f4cd`](e8f74f4)]: - @shopify/polaris@10.18.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Merged
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
### WHY are these changes introduced? Supports Shopify#7960 ### WHAT is this pull request doing? Adds `outline` prop to `Box`
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris@10.18.0 ### Minor Changes - [Shopify#7992](Shopify#7992) [`e8f74f4cd`](Shopify@e8f74f4) Thanks [@aveline](https://github.com/aveline)! - Added support for `outline` to `Box` ### Patch Changes - [Shopify#7988](Shopify#7988) [`382784f4e`](Shopify@382784f) Thanks [@kyledurand](https://github.com/kyledurand)! - Reduced spacing on ChoiceList children - [Shopify#7899](Shopify#7899) [`930f077eb`](Shopify@930f077) Thanks [@jeradg](https://github.com/jeradg)! - Fixed a bug where Tooltips nested in Scrollable containers sometimes don't update their positions correctly - [Shopify#7831](Shopify#7831) [`47487ee0c`](Shopify@47487ee) Thanks [@acmertz](https://github.com/acmertz)! - Updated the focus helper functions to no longer treat buttons with `aria-disabled="true"` and `tabindex="-1" (but no`disabled\` attribute) as focusable. ## @shopify/plugin-polaris@0.0.25 ## polaris.shopify.com@0.28.2 ### Patch Changes - Updated dependencies \[[`382784f4e`](Shopify@382784f), [`930f077eb`](Shopify@930f077), [`47487ee0c`](Shopify@47487ee), [`e8f74f4cd`](Shopify@e8f74f4)]: - @shopify/polaris@10.18.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Supports #7960
WHAT is this pull request doing?
Adds
outlineprop toBox