Bump minimum Node version to 16.17.0 #8212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
aaronccasanova
requested review from
alex-page and
sam-b-rose
and removed request for
alex-page
sam-b-rose
approved these changes
Jan 31, 2023
BPScott
approved these changes
Feb 2, 2023
There was a problem hiding this comment.
Over in the other node bump pr I was talking about using the first LTS version of a given major version unless there's a good reason to use a newer version. This seems like a good reason :)
aaronccasanova
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps the minimum Node.js version to v16.17.0 LTS. Note: The main motivation for the version bump is to add support for the Node.js util.parseArgs module (which was back ported to v16.17.0). The built-in
util.parseArgsmodule is still marked experimental, but I would like to establish support now (in Polaris v11) so we can remove CLI arg parsing libraries in our packages (e.g. polaris-migrator) and use in future integrations.