-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[Layout foundations] Update layout component docs and guidance #8379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
c5f2ee8
Updated Bleed tabs
nayeobkim 74db111
Update `Bleed` horizontal description
nayeobkim 6f1a95c
Update `bleed` example description
nayeobkim 8f6a110
Update `Box` example description
nayeobkim d436f33
Update `AlphaCard` example description
nayeobkim f981aca
Update the Column example description
nayeobkim c3064f2
Remove Default tab example
nayeobkim 8223e81
Update `Inline` example description
nayeobkim 98f7b0f
Update `Inline` Related component description and `AlphaStack` exampl…
nayeobkim 711a2cb
Remove default from `Box` and added Related components to `AlphaCard`
nayeobkim 586f1e9
Update Related component copy of `AlphaCard`
nayeobkim cdac262
Update `Bleed` code examples
aveline 0c49c62
Update `AlphaStack` code examples
chazdean fc806ff
Update `Card` docs
aveline 96c82b1
Update `Columns` docs
aveline ec2488d
Update `Inline` code examples
chazdean 24ca242
Fix `Inline` code example
chazdean 9d49b08
Update `Columns` code examples
aveline ae2ca7f
Update columns-with-varying-gap.tsx
aveline 0d37da7
Remove `Inline` default example
chazdean 51443d4
Update `Inline` gap example description
chazdean a72224e
Update `Box` code examples
aveline fefbd77
Remove `fullWidth` prop from examples
chazdean 7d37391
Update `AlphaStack` example description to include fullWidth
chazdean 7bbf422
Revert changes to rename `AlphaCard` to `Card`
laurkim 572112c
Add changeset
laurkim 3b2deaa
Fix `Box` padding example
laurkim 938fe78
Copy updates
laurkim 5938c32
Add search keywords to layout components
laurkim f94ea77
Update `AlphaStack` full width description
laurkim 37ddb69
Update routing for `AlphaStack`
laurkim 5b45ba4
Update `AlphaStack` and `Inline` search terms
laurkim File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'polaris.shopify.com': patch | ||
--- | ||
|
||
Updated documentation and guidance for `AlphaCard`, `AlphaStack`, `Box`, `Bleed`, `Columns`, and `Inline` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 11 additions & 12 deletions
23
polaris.shopify.com/content/components/layout-and-structure/alpha-stack.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 7 additions & 8 deletions
15
polaris.shopify.com/content/components/layout-and-structure/columns.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 3 additions & 1 deletion
4
polaris.shopify.com/content/components/layout-and-structure/divider.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
35 changes: 21 additions & 14 deletions
35
polaris.shopify.com/content/components/layout-and-structure/inline.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,35 +1,42 @@ | ||
--- | ||
title: Inline | ||
description: Use to arrange items in a horizontal row with equal spacing around them. Items wrap onto multiple lines when needed. | ||
description: Use to display children horizontally in a row. Based on CSS Flexbox. | ||
category: Layout and structure | ||
keywords: | ||
- layout | ||
- inline | ||
- flexbox | ||
- flex | ||
- responsive | ||
- flexible items | ||
- row of components | ||
- rows | ||
- vertical centering | ||
- horizontal row of components | ||
- stack | ||
status: | ||
value: Alpha | ||
message: This component is a work in progress and ready for exploratory usage, with breaking changes expected in minor version updates. Please use with caution. Learn more about our [component lifecycles](/getting-started/components-lifecycle). | ||
examples: | ||
- fileName: inline-default.tsx | ||
title: Default | ||
description: >- | ||
Items are vertically centered with 16px of space around them. They’ll wrap onto multiple lines when needed. | ||
- fileName: inline-with-non-wrapping.tsx | ||
title: Non-wrapping | ||
description: >- | ||
Use to create Inline where the children will not wrap to new rows on small screens. | ||
The default wrapping behavior of children can be overridden using the `wrap` prop. | ||
- fileName: inline-with-gap.tsx | ||
title: Gap | ||
description: >- | ||
Use to control gaps around items in inline in standard increments. | ||
- fileName: inline-with-vertical-alignment.tsx | ||
title: Vertical alignment | ||
Control the horizontal and vertical space between children using the `gap` prop. The `gap` prop supports responsive spacing with the [Breakpoints tokens](https://polaris.shopify.com/tokens/breakpoints). | ||
- fileName: inline-with-block-align.tsx | ||
title: Block align | ||
description: >- | ||
Use to vertically align Inline. | ||
- fileName: inline-with-horizontal-alignment.tsx | ||
title: Horizontal alignment | ||
Control the vertical alignment of children using the `blockAlign` prop. | ||
- fileName: inline-with-align.tsx | ||
title: Align | ||
description: >- | ||
Use to horizontally align Inline. | ||
Control the horizontal alignment of children using the `align` prop. | ||
--- | ||
|
||
## Related components | ||
|
||
- To display elements vertically, [use the AlphaStack component](https://polaris.shopify.com/components/layout-and-structure/alpha-stack) | ||
- To create the large-scale structure of pages, [use the Columns component](https://polaris.shopify.com/components/layout-and-structure/columns) | ||
- To display elements vertically, [use the AlphaStack component](https://polaris.shopify.com/components/alphastack) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.