Skip to content

[polaris.shopify.com] Move props to cache and automate #8493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2023
Merged

[polaris.shopify.com] Move props to cache and automate #8493

merged 1 commit into from
Feb 27, 2023

Conversation

kyledurand
Copy link
Member

Closes #8487

@kyledurand kyledurand self-assigned this Feb 24, 2023
@kyledurand kyledurand force-pushed the automate-get-props branch 2 times, most recently from c2f227d to fa3b890 Compare February 24, 2023 15:10
@kyledurand kyledurand requested a review from alex-page February 24, 2023 16:21
alex-page
alex-page reviewed Feb 26, 2023
View reviewed changes
polaris.shopify.com/package.json
"gen-sitemap": "yarn next-sitemap",
"get-props": "tsc ./scripts/get-props/src/get-props.ts --target esnext --module node16 --types \"react\" --outDir ./scripts/tmp && node ./scripts/tmp/scripts/get-props/src/get-props.js && rm -rf ./scripts/tmp",
"gen-assets": "node scripts/gen-assets.mjs"
"gen-assets": "node scripts/gen-assets.mjs && yarn get-props"
Copy link
Member

@alex-page alex-page Feb 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure when get-props needs to be ran. If possible we could run it at the same time as genSiteMap and genCacheJson. Then the build should be a little bit faster running these scripts at the same time.

const genAssets = async () => {
  await Promise.all([genSiteMap(), genCacheJson(), getProps()]);
  await genOgImages();
};

This would require tsc ./scripts/get-props/src/get-props.ts --target esnext --module node16 --types \"react\" --outDir ./scripts/tmp && node ./scripts/tmp/scripts/get-props/src/get-props.js && rm -rf ./scripts/tmp to be moved into a file like scripts/get-props. Then we can run node scripts/get-props if we need to run it by itself.

@kyledurand kyledurand merged commit a6fb3fb into main Feb 27, 2023
@kyledurand kyledurand deleted the automate-get-props branch February 27, 2023 19:37
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request Feb 27, 2023
Merged
laurkim pushed a commit that referenced this pull request Mar 6, 2023
@shopify-github-actions-access @github-actions
Version Packages (#8504)
420f8da 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/polaris-migrator@0.15.0

### Minor Changes

- [#8229](#8229)
[`e21fd8d79`](e21fd8d)
Thanks [@aveline](https://github.com/aveline)! - Created migration to
rename `Card` to `LegacyCard`

### Patch Changes

- Updated dependencies
\[[`6c0dda128`](6c0dda1)]:
    -   @shopify/polaris-tokens@6.7.0
    -   @shopify/stylelint-polaris@8.0.1

## @shopify/polaris@10.33.0

### Minor Changes

- [#8514](#8514)
[`78d686db5`](78d686d)
Thanks [@lgriffee](https://github.com/lgriffee)! - Add additional
changes for migrating `legacy` custom properties from `v10` to `v11`


- [#8512](#8512)
[`b77c1fe51`](b77c1fe)
Thanks [@fatimasajadi](https://github.com/fatimasajadi)! - Add
onMouseEnter prop to the each item on the ActionList component


- [#8530](#8530)
[`bec50d4d8`](bec50d4)
Thanks [@kyledurand](https://github.com/kyledurand)! - Removed alignment
defaults from Inline and AlphaStack


- [#8448](#8448)
[`590e495fd`](590e495)
Thanks [@alex-page](https://github.com/alex-page)! - [Text] adds
optional numeric font variant to render characters with a monospace
apperance and consistent height and width


- [#8130](#8130)
[`6c0dda128`](6c0dda1)
Thanks [@mrcthms](https://github.com/mrcthms)! - - Added a `suffix` prop
to `Tooltip`
- Improved the UX of `Tooltip` by refining open and close animations and
adding an arrow pointing to the center of the `activator`
- Added the `EmpemeralPresenceManager` to manage the presence of
non-blocking overlays, like `Tooltip` and `Toast`


- [#8556](#8556)
[`de3a925a7`](de3a925)
Thanks [@laurkim](https://github.com/laurkim)! - Deprecated `Stack` and
`Stack.Item` and updated documentation on style guide


- [#8498](#8498)
[`624751155`](6247511)
Thanks [@lgriffee](https://github.com/lgriffee)! - Migrated `legacy`
custom properties from `v10` to `v11`

### Patch Changes

- [#8534](#8534)
[`eeb8a4fc5`](eeb8a4f)
Thanks [@laurkim](https://github.com/laurkim)! - Migrated usage of
`Stack` to `LegacyStack`


- [#8540](#8540)
[`70c166290`](70c1662)
Thanks [@Ipriyankrajai](https://github.com/Ipriyankrajai)! - Fixed
`ActionList` item `suffix` having extra padding when wrapped


- [#8523](#8523)
[`f644ad671`](f644ad6)
Thanks [@kyledurand](https://github.com/kyledurand)! - Fixed deprecation
warning on Card


- [#8531](#8531)
[`7ecc8a9a6`](7ecc8a9)
Thanks [@chloerice](https://github.com/chloerice)! - - Fixed header of
`IndexTable` with `bulkActions` not having border radius
- Fixed header of `selectable` `ResourceList` not having border radius
- Fixed `selectable` `ResourceList` with no `bulkActions` having extra
bottom padding in select mode
- Fixed last `ResourceItem` in a `selectable` `ResourceList` with
`bulkActions` having a border radius when in select mode
- Updated dependencies
\[[`6c0dda128`](6c0dda1),
[`886da4fc3`](886da4f)]:
    -   @shopify/polaris-tokens@6.7.0
    -   @shopify/polaris-icons@6.11.3

## @shopify/polaris-tokens@6.7.0

### Minor Changes

- [#8130](#8130)
[`6c0dda128`](6c0dda1)
Thanks [@mrcthms](https://github.com/mrcthms)! - - Added a `suffix` prop
to `Tooltip`
- Improved the UX of `Tooltip` by refining open and close animations and
adding an arrow pointing to the center of the `activator`
- Added the `EmpemeralPresenceManager` to manage the presence of
non-blocking overlays, like `Tooltip` and `Toast`

## @shopify/polaris-cli@0.1.14

### Patch Changes

- Updated dependencies
\[[`e21fd8d79`](e21fd8d)]:
    -   @shopify/polaris-migrator@0.15.0

## @shopify/polaris-icons@6.11.3

### Patch Changes

- [#8505](#8505)
[`886da4fc3`](886da4f)
Thanks [@lfroms](https://github.com/lfroms)! - Converted percentage
fill-opacity to float in two icons for better compatibility

## @shopify/stylelint-polaris@8.0.1

### Patch Changes

- Updated dependencies
\[[`6c0dda128`](6c0dda1)]:
    -   @shopify/polaris-tokens@6.7.0

## polaris.shopify.com@0.38.0

### Minor Changes

- [#8129](#8129)
[`6d3843755`](6d38437)
Thanks [@jesstelford](https://github.com/jesstelford)! - Patterns
documentation is now written in Markdown to match all other site
content.


- [#8130](#8130)
[`6c0dda128`](6c0dda1)
Thanks [@mrcthms](https://github.com/mrcthms)! - - Added a `suffix` prop
to `Tooltip`
- Improved the UX of `Tooltip` by refining open and close animations and
adding an arrow pointing to the center of the `activator`
- Added the `EmpemeralPresenceManager` to manage the presence of
non-blocking overlays, like `Tooltip` and `Toast`


- [#8559](#8559)
[`668afa51c`](668afa5)
Thanks [@jjgali](https://github.com/jjgali)! - Update voice and tone of
Trustworthy experience value.

### Patch Changes

- [#8534](#8534)
[`eeb8a4fc5`](eeb8a4f)
Thanks [@laurkim](https://github.com/laurkim)! - Migrated usage of
`Stack` to `LegacyStack`


- [#8519](#8519)
[`f411cf0b6`](f411cf0)
Thanks [@kyledurand](https://github.com/kyledurand)! - Added missing
redirect, updated content


- [#8553](#8553)
[`d2672648a`](d267264)
Thanks [@gwyneplaine](https://github.com/gwyneplaine)! - Fix legacy
patterns wrongly being categorised as deprecated. These are now
correctly labeled "legacy"


- [#8556](#8556)
[`de3a925a7`](de3a925)
Thanks [@laurkim](https://github.com/laurkim)! - Deprecated `Stack` and
`Stack.Item` and updated documentation on style guide


- [#8493](#8493)
[`a6fb3fbb7`](a6fb3fb)
Thanks [@kyledurand](https://github.com/kyledurand)! - Moved props.json
to cache and automate generation


- [#8528](#8528)
[`191ff96df`](191ff96)
Thanks [@jesstelford](https://github.com/jesstelford)! - Fixed grid
alignment on component group page

- Updated dependencies
\[[`eeb8a4fc5`](eeb8a4f),
[`78d686db5`](78d686d),
[`70c166290`](70c1662),
[`b77c1fe51`](b77c1fe),
[`bec50d4d8`](bec50d4),
[`f644ad671`](f644ad6),
[`590e495fd`](590e495),
[`6c0dda128`](6c0dda1),
[`de3a925a7`](de3a925),
[`886da4fc3`](886da4f),
[`7ecc8a9a6`](7ecc8a9),
[`624751155`](6247511)]:
    -   @shopify/polaris@10.33.0
    -   @shopify/polaris-tokens@6.7.0
    -   @shopify/polaris-icons@6.11.3

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
juzser pushed a commit to juzser/polaris that referenced this pull request Jul 27, 2023
@kyledurand @juzser
[polaris.shopify.com] Move props to cache and automate (Shopify#8493)
9311a79 
Closes Shopify#8487
juzser pushed a commit to juzser/polaris that referenced this pull request Jul 27, 2023
@shopify-github-actions-access @github-actions @juzser
Version Packages (Shopify#8504)
5e15ce4 
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @shopify/polaris-migrator@0.15.0

### Minor Changes

- [Shopify#8229](Shopify#8229)
[`e21fd8d79`](Shopify@e21fd8d)
Thanks [@aveline](https://github.com/aveline)! - Created migration to
rename `Card` to `LegacyCard`

### Patch Changes

- Updated dependencies
\[[`6c0dda128`](Shopify@6c0dda1)]:
    -   @shopify/polaris-tokens@6.7.0
    -   @shopify/stylelint-polaris@8.0.1

## @shopify/polaris@10.33.0

### Minor Changes

- [Shopify#8514](Shopify#8514)
[`78d686db5`](Shopify@78d686d)
Thanks [@lgriffee](https://github.com/lgriffee)! - Add additional
changes for migrating `legacy` custom properties from `v10` to `v11`


- [Shopify#8512](Shopify#8512)
[`b77c1fe51`](Shopify@b77c1fe)
Thanks [@fatimasajadi](https://github.com/fatimasajadi)! - Add
onMouseEnter prop to the each item on the ActionList component


- [Shopify#8530](Shopify#8530)
[`bec50d4d8`](Shopify@bec50d4)
Thanks [@kyledurand](https://github.com/kyledurand)! - Removed alignment
defaults from Inline and AlphaStack


- [Shopify#8448](Shopify#8448)
[`590e495fd`](Shopify@590e495)
Thanks [@alex-page](https://github.com/alex-page)! - [Text] adds
optional numeric font variant to render characters with a monospace
apperance and consistent height and width


- [Shopify#8130](Shopify#8130)
[`6c0dda128`](Shopify@6c0dda1)
Thanks [@mrcthms](https://github.com/mrcthms)! - - Added a `suffix` prop
to `Tooltip`
- Improved the UX of `Tooltip` by refining open and close animations and
adding an arrow pointing to the center of the `activator`
- Added the `EmpemeralPresenceManager` to manage the presence of
non-blocking overlays, like `Tooltip` and `Toast`


- [Shopify#8556](Shopify#8556)
[`de3a925a7`](Shopify@de3a925)
Thanks [@laurkim](https://github.com/laurkim)! - Deprecated `Stack` and
`Stack.Item` and updated documentation on style guide


- [Shopify#8498](Shopify#8498)
[`624751155`](Shopify@6247511)
Thanks [@lgriffee](https://github.com/lgriffee)! - Migrated `legacy`
custom properties from `v10` to `v11`

### Patch Changes

- [Shopify#8534](Shopify#8534)
[`eeb8a4fc5`](Shopify@eeb8a4f)
Thanks [@laurkim](https://github.com/laurkim)! - Migrated usage of
`Stack` to `LegacyStack`


- [Shopify#8540](Shopify#8540)
[`70c166290`](Shopify@70c1662)
Thanks [@Ipriyankrajai](https://github.com/Ipriyankrajai)! - Fixed
`ActionList` item `suffix` having extra padding when wrapped


- [Shopify#8523](Shopify#8523)
[`f644ad671`](Shopify@f644ad6)
Thanks [@kyledurand](https://github.com/kyledurand)! - Fixed deprecation
warning on Card


- [Shopify#8531](Shopify#8531)
[`7ecc8a9a6`](Shopify@7ecc8a9)
Thanks [@chloerice](https://github.com/chloerice)! - - Fixed header of
`IndexTable` with `bulkActions` not having border radius
- Fixed header of `selectable` `ResourceList` not having border radius
- Fixed `selectable` `ResourceList` with no `bulkActions` having extra
bottom padding in select mode
- Fixed last `ResourceItem` in a `selectable` `ResourceList` with
`bulkActions` having a border radius when in select mode
- Updated dependencies
\[[`6c0dda128`](Shopify@6c0dda1),
[`886da4fc3`](Shopify@886da4f)]:
    -   @shopify/polaris-tokens@6.7.0
    -   @shopify/polaris-icons@6.11.3

## @shopify/polaris-tokens@6.7.0

### Minor Changes

- [Shopify#8130](Shopify#8130)
[`6c0dda128`](Shopify@6c0dda1)
Thanks [@mrcthms](https://github.com/mrcthms)! - - Added a `suffix` prop
to `Tooltip`
- Improved the UX of `Tooltip` by refining open and close animations and
adding an arrow pointing to the center of the `activator`
- Added the `EmpemeralPresenceManager` to manage the presence of
non-blocking overlays, like `Tooltip` and `Toast`

## @shopify/polaris-cli@0.1.14

### Patch Changes

- Updated dependencies
\[[`e21fd8d79`](Shopify@e21fd8d)]:
    -   @shopify/polaris-migrator@0.15.0

## @shopify/polaris-icons@6.11.3

### Patch Changes

- [Shopify#8505](Shopify#8505)
[`886da4fc3`](Shopify@886da4f)
Thanks [@lfroms](https://github.com/lfroms)! - Converted percentage
fill-opacity to float in two icons for better compatibility

## @shopify/stylelint-polaris@8.0.1

### Patch Changes

- Updated dependencies
\[[`6c0dda128`](Shopify@6c0dda1)]:
    -   @shopify/polaris-tokens@6.7.0

## polaris.shopify.com@0.38.0

### Minor Changes

- [Shopify#8129](Shopify#8129)
[`6d3843755`](Shopify@6d38437)
Thanks [@jesstelford](https://github.com/jesstelford)! - Patterns
documentation is now written in Markdown to match all other site
content.


- [Shopify#8130](Shopify#8130)
[`6c0dda128`](Shopify@6c0dda1)
Thanks [@mrcthms](https://github.com/mrcthms)! - - Added a `suffix` prop
to `Tooltip`
- Improved the UX of `Tooltip` by refining open and close animations and
adding an arrow pointing to the center of the `activator`
- Added the `EmpemeralPresenceManager` to manage the presence of
non-blocking overlays, like `Tooltip` and `Toast`


- [Shopify#8559](Shopify#8559)
[`668afa51c`](Shopify@668afa5)
Thanks [@jjgali](https://github.com/jjgali)! - Update voice and tone of
Trustworthy experience value.

### Patch Changes

- [Shopify#8534](Shopify#8534)
[`eeb8a4fc5`](Shopify@eeb8a4f)
Thanks [@laurkim](https://github.com/laurkim)! - Migrated usage of
`Stack` to `LegacyStack`


- [Shopify#8519](Shopify#8519)
[`f411cf0b6`](Shopify@f411cf0)
Thanks [@kyledurand](https://github.com/kyledurand)! - Added missing
redirect, updated content


- [Shopify#8553](Shopify#8553)
[`d2672648a`](Shopify@d267264)
Thanks [@gwyneplaine](https://github.com/gwyneplaine)! - Fix legacy
patterns wrongly being categorised as deprecated. These are now
correctly labeled "legacy"


- [Shopify#8556](Shopify#8556)
[`de3a925a7`](Shopify@de3a925)
Thanks [@laurkim](https://github.com/laurkim)! - Deprecated `Stack` and
`Stack.Item` and updated documentation on style guide


- [Shopify#8493](Shopify#8493)
[`a6fb3fbb7`](Shopify@a6fb3fb)
Thanks [@kyledurand](https://github.com/kyledurand)! - Moved props.json
to cache and automate generation


- [Shopify#8528](Shopify#8528)
[`191ff96df`](Shopify@191ff96)
Thanks [@jesstelford](https://github.com/jesstelford)! - Fixed grid
alignment on component group page

- Updated dependencies
\[[`eeb8a4fc5`](Shopify@eeb8a4f),
[`78d686db5`](Shopify@78d686d),
[`70c166290`](Shopify@70c1662),
[`b77c1fe51`](Shopify@b77c1fe),
[`bec50d4d8`](Shopify@bec50d4),
[`f644ad671`](Shopify@f644ad6),
[`590e495fd`](Shopify@590e495),
[`6c0dda128`](Shopify@6c0dda1),
[`de3a925a7`](Shopify@de3a925),
[`886da4fc3`](Shopify@886da4f),
[`7ecc8a9a6`](Shopify@7ecc8a9),
[`624751155`](Shopify@6247511)]:
    -   @shopify/polaris@10.33.0
    -   @shopify/polaris-tokens@6.7.0
    -   @shopify/polaris-icons@6.11.3

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alex-page alex-page alex-page approved these changes

Assignees

@kyledurand kyledurand

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[polaris.shopify.com] props.json can get out of sync with polaris-react

2 participants

@kyledurand @alex-page