Skip to content

Stylelint comment cleanup #8644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 13, 2023
Merged

Stylelint comment cleanup #8644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5030caa
Remove single line comments
alex-page Mar 13, 2023
491811c
Add back necessary comments
alex-page Mar 13, 2023
c06d5f7
Remove multiline disables
alex-page Mar 13, 2023
e5c3eb3
Add back necessary multiline disables
alex-page Mar 13, 2023
8bf8882
Fix linting issues
alex-page Mar 13, 2023
5dc27ef
Create late-vans-trade.md
alex-page Mar 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/late-vans-trade.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/polaris': patch
---

Remove unnecessary stylelint-disable comments
3 changes: 0 additions & 3 deletions polaris-react/playground/DetailsPage.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
@import '../src/styles/common';

.ContextControl {
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
display: flex;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
align-items: center;
padding: 0 var(--p-space-3);
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
height: $top-bar-height;
}

Expand Down
7 changes: 0 additions & 7 deletions polaris-react/src/components/ActionList/ActionList.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,7 @@
@include unstyled-button;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
@include focus-ring;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
display: block;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
width: 100%;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
min-height: var(--pc-action-list-item-min-height);
Expand Down Expand Up @@ -95,13 +93,9 @@
.Prefix {
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
@include recolor-icon(var(--p-icon));
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
display: flex;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
flex: 0 0 auto;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
justify-content: center;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
align-items: center;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
height: var(--pc-action-list-image-size);
Expand All @@ -127,6 +121,5 @@
.Text {
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
@include layout-flex-fix;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
flex: 1 1 auto;
}
5 changes: 1 addition & 4 deletions polaris-react/src/components/ActionMenu/ActionMenu.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,11 @@
.ActionMenu {
// Needed for JS calculations
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
width: 100%;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
display: flex;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
justify-content: flex-end;

@media print {
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
// stylelint-disable-next-line declaration-no-important -- Enforce print styles
display: none !important;
}
}
5 changes: 0 additions & 5 deletions polaris-react/src/components/ActionMenu/components/Actions/Actions.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,13 @@
@import '../../../../styles/common';

.ActionsLayout {
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
display: flex;
flex-wrap: wrap;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
align-items: center;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
justify-content: flex-end;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
flex: 1 1 auto;

> * {
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
flex: 0 0 auto;
}
}
2 changes: 0 additions & 2 deletions polaris-react/src/components/AlphaStack/AlphaStack.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@
--pc-stack-gap-lg: var(--pc-stack-gap-md);
--pc-stack-gap-xl: var(--pc-stack-gap-lg);
// stylelint-enable

// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
display: flex;
// stylelint-disable-next-line -- local component custom property is required for flex direction
flex-direction: var(--pc-stack-order);
Expand Down
1 change: 0 additions & 1 deletion polaris-react/src/components/AppProvider/AppProvider.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ button {
}

html {
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
position: relative;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
font-size: 100%;
Expand Down
4 changes: 0 additions & 4 deletions polaris-react/src/components/Autocomplete/Autocomplete.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,7 @@
.Loading {
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
display: flex;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
justify-content: center;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
align-items: center;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
width: 100%;
padding: var(--p-space-2) var(--p-space-4);
}
Expand Down
9 changes: 0 additions & 9 deletions polaris-react/src/components/Autocomplete/components/MappedAction/MappedAction.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,7 @@
.Action {
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
@include focus-ring;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
display: block;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
width: 100%;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
min-height: var(--pc-mapped-actions-item-min-height);
Expand Down Expand Up @@ -94,22 +92,16 @@
}

.Content {
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
display: flex;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
align-items: center;
}

.Prefix {
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
@include recolor-icon(var(--p-icon));
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
display: flex;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
flex: 0 0 auto;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
justify-content: center;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
align-items: center;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
height: var(--pc-mapped-actions-image-size);
Expand All @@ -136,7 +128,6 @@
.Text {
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
@include layout-flex-fix;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
flex: 1 1 auto;

.ContentWrap {
Expand Down
2 changes: 0 additions & 2 deletions polaris-react/src/components/Autocomplete/components/MappedOption/MappedOption.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
@import '../../../../styles/common';

.Content {
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
display: flex;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
flex: 1;

// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
Expand Down
18 changes: 0 additions & 18 deletions polaris-react/src/components/Avatar/Avatar.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,7 @@
--pc-avatar-medium-size: 40px;
--pc-avatar-large-size: 60px;
// stylelint-enable
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
position: relative;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
display: block;
overflow: hidden;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
Expand All @@ -23,7 +21,6 @@

&::after {
content: '';
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
display: block;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
padding-bottom: 100%;
Expand Down Expand Up @@ -110,43 +107,28 @@
}

.Image {
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
position: absolute;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
top: 50%;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
left: 50%;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
width: 100%;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
height: 100%;
border-radius: inherit;
transform: translate(-50%, -50%);
object-fit: cover;
}

.Initials {
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
position: absolute;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
top: 0;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
right: 0;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
display: flex;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
align-items: center;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
justify-content: center;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
width: 100%;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
height: 100%;
}

.Svg {
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
width: 100%;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
height: 100%;
}
6 changes: 0 additions & 6 deletions polaris-react/src/components/Backdrop/Backdrop.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,10 @@
.Backdrop {
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
position: fixed;
z-index: var(--p-z-index-10);
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
top: 0;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
right: 0;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
bottom: 0;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
left: 0;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
display: block;
background-color: var(--p-backdrop);
animation: var(--p-keyframes-fade-in) var(--p-duration-200) 1 forwards;
Expand Down
4 changes: 0 additions & 4 deletions polaris-react/src/components/Badge/Badge.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,7 @@
--pc-badge-horizontal-padding: var(--p-space-2);
--pc-badge-vertical-padding: var(--p-space-05);
// stylelint-enable
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
display: inline-flex;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
align-items: center;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
padding: var(--pc-badge-vertical-padding) var(--pc-badge-horizontal-padding);
Expand Down Expand Up @@ -57,9 +55,7 @@
}

.PipContainer {
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
display: grid;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
align-items: center;
margin-left: calc(-1 * var(--p-space-05));
margin-right: var(--p-space-1);
Expand Down
2 changes: 0 additions & 2 deletions polaris-react/src/components/Badge/components/Pip/Pip.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
--pc-pip-size: var(--p-space-2);
--pc-pip-color: var(--p-icon);
// stylelint-enable
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
display: inline-block;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
color: var(--pc-pip-color);
Expand All @@ -14,7 +13,6 @@
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
border: var(--p-border-width-2) solid var(--pc-pip-color);
border-radius: var(--p-border-radius-full);
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
flex-shrink: 0;
}

Expand Down
13 changes: 0 additions & 13 deletions polaris-react/src/components/Banner/Banner.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,7 @@
--pc-banner-secondary-action-horizontal-padding: var(--p-space-3);
--pc-banner-secondary-action-vertical-padding: var(--p-space-2);
// stylelint-enable
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
position: relative;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
display: flex;

// stylelint-disable selector-max-class, selector-max-specificity -- generated by polaris-migrator DO NOT COPY
Expand Down Expand Up @@ -151,11 +149,8 @@
padding: var(--p-space-4);

.Dismiss {
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
top: var(--p-space-4);
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
right: var(--p-space-3);
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
position: absolute;
}

Expand All @@ -181,11 +176,8 @@
}

.Dismiss {
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
right: var(--p-space-4);
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
top: var(--p-space-5);
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
position: absolute;
}
}
Expand All @@ -201,7 +193,6 @@
.SecondaryAction {
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
@include unstyled-button;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
display: inline-block;
text-align: left;
text-decoration: none;
Expand Down Expand Up @@ -265,7 +256,6 @@
}

.loading {
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
position: relative;
color: transparent;
pointer-events: none;
Expand All @@ -274,11 +264,8 @@
.Spinner {
// stylelint-disable-next-line -- Polaris component custom properties
--pc-spinner-size: var(--p-space-5);
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
position: absolute;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
top: 50%;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
left: 50%;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
margin-top: calc(-1 * (var(--pc-spinner-size) / 2));
Expand Down
5 changes: 0 additions & 5 deletions polaris-react/src/components/Breadcrumbs/Breadcrumbs.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,9 @@
.Breadcrumb {
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
@include unstyled-button;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
position: relative;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
display: flex;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
align-items: center;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
justify-content: center;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
min-height: control-height();
Expand Down Expand Up @@ -56,7 +52,6 @@
.Content {
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
@include truncate;
// stylelint-disable-next-line -- generated by polaris-migrator DO NOT COPY
position: relative;
}

Expand Down
Loading