This repository was archived by the owner on Sep 30, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix order of focusable selectors #9039
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
/snapit |
🫰✨ Thanks @acmertz! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/polaris-cli@0.0.0-snapshot-release-20230420205546 yarn add @shopify/polaris@0.0.0-snapshot-release-20230420205546 |
acmertz
approved these changes
Apr 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I used the snapshot from #9039 (comment) to test this in web and confirm that the fix from #7831 still works.
Merged
kyledurand
pushed a commit
that referenced
this pull request
Apr 24, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris@10.47.2 ### Patch Changes - [#9039](#9039) [`cda94e7a6`](cda94e7) Thanks [@matallo](https://github.com/matallo)! - Updated the focus helper functions, order of selectors for `button:not(:disabled):not([aria-disabled="true"]):not([tabindex="-1"])` was returning an error, moved `:not(:disabled)` to the end. ## @shopify/polaris-cli@0.1.33 ## polaris.shopify.com@0.50.3 ### Patch Changes - Updated dependencies \[[`cda94e7a6`](cda94e7)]: - @shopify/polaris@10.47.2 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris@10.47.2 ### Patch Changes - [Shopify#9039](Shopify#9039) [`cda94e7a6`](Shopify@cda94e7) Thanks [@matallo](https://github.com/matallo)! - Updated the focus helper functions, order of selectors for `button:not(:disabled):not([aria-disabled="true"]):not([tabindex="-1"])` was returning an error, moved `:not(:disabled)` to the end. ## @shopify/polaris-cli@0.1.33 ## polaris.shopify.com@0.50.3 ### Patch Changes - Updated dependencies \[[`cda94e7a6`](Shopify@cda94e7)]: - @shopify/polaris@10.47.2 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ascherkus
pushed a commit
to ascherkus/polaris
that referenced
this pull request
Feb 19, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris@10.47.2 ### Patch Changes - [Shopify#9039](Shopify#9039) [`cda94e7a6`](Shopify@abc170f) Thanks [@matallo](https://github.com/matallo)! - Updated the focus helper functions, order of selectors for `button:not(:disabled):not([aria-disabled="true"]):not([tabindex="-1"])` was returning an error, moved `:not(:disabled)` to the end. ## @shopify/polaris-cli@0.1.33 ## polaris.shopify.com@0.50.3 ### Patch Changes - Updated dependencies \[[`cda94e7a6`](Shopify@abc170f)]: - @shopify/polaris@10.47.2 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes an error when using
Modal
component with testing libraries.WHAT is this pull request doing?
Order of selectors for
button:not(:disabled):not([aria-disabled="true"]):not([tabindex="-1"])
was returning an error, and needed:not(:disabled)
to be used last.How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
Copy-paste this code in
playground/Playground.tsx
:🎩 checklist
README.md
with documentation changes