This repository was archived by the owner on Sep 30, 2025. It is now read-only.
Swap bg-subdued and bg-secondary tokens
#9498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronccasanova
force-pushed
the
swap-bg-tokens
branch
from
735eaa3 to
55e5cb8
Compare
aaronccasanova
added
the
🤖Skip Changelog
|
/snapit |
|
🫰✨ Thanks @aaronccasanova! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/polaris-cli@0.0.0-snapshot-release-20230622163123yarn add @shopify/polaris-codemods@0.0.0-snapshot-release-20230622163123yarn add @shopify/polaris-migrator@0.0.0-snapshot-release-20230622163123yarn add @shopify/polaris@0.0.0-snapshot-release-20230622163123yarn add @shopify/polaris-tokens@0.0.0-snapshot-release-20230622163123yarn add @shopify/stylelint-polaris@0.0.0-snapshot-release-20230622163123 |
aaronccasanova
commented
Jun 22, 2023
polaris-react/src/components/Modal/components/Header/Header.tsx
Outdated
Show resolved
Hide resolved
aaronccasanova
requested review from
kyledurand,
laurkim,
aveline,
sam-b-rose and
chloerice
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
5 tasks
mattkubej
added a commit
that referenced
this pull request
Sep 22, 2023
### WHY are these changes introduced? A [previous change](#9498) went in to replace some instances of `bg-subdued` with `bg-secondary-experimental`. There are now some inconsistencies between our Table and List usages of these background colors. Additionally, there is a migration planned for next week that will replace all `bg-subdued` instances with `bg-secondary`. ### WHAT is this pull request doing? To resolve the inconsistencies and prepare for the migration, this pull request replaces instances of `bg-secondary-experiement` with the `bg-subdued` token within `DataTable` and `IndexTable`. NOTE: the existing usage of `bg-secondary-experiment` is not likely seen visually, because header cells defined their background as `bg-subdued` and sit on top of the row with `bg-secondary-experiment`. Likely further improvement here, but this will combat the incorrect color from leaking through. ### How to 🎩 Validate that `DataTable` and `IndexTable` do not render row backgrounds with `secondary`, but with `subdued`. - Storybook - [DataTable](https://storybook.web.swap-table-secondary-with-subdued.matt-kubej.us.spin.dev/?path=/story/all-components-datatable--default&globals=polarisSummerEditions2023:true;polarisSummerEditions2023ShadowBevelOptOut:true) - [IndexTable](https://storybook.web.swap-table-secondary-with-subdued.matt-kubej.us.spin.dev/?path=/story/all-components-indextable--default&globals=polarisSummerEditions2023:true;polarisSummerEditions2023ShadowBevelOptOut:true) - Web - [Product Index](https://admin.web.swap-table-secondary-with-subdued.matt-kubej.us.spin.dev/store/shop1/products) (using snapshot and loaded with products to test sticky header) ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [x] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
ascherkus
pushed a commit
to ascherkus/polaris
that referenced
this pull request
Feb 19, 2025
…#10649) ### WHY are these changes introduced? A [previous change](Shopify#9498) went in to replace some instances of `bg-subdued` with `bg-secondary-experimental`. There are now some inconsistencies between our Table and List usages of these background colors. Additionally, there is a migration planned for next week that will replace all `bg-subdued` instances with `bg-secondary`. ### WHAT is this pull request doing? To resolve the inconsistencies and prepare for the migration, this pull request replaces instances of `bg-secondary-experiement` with the `bg-subdued` token within `DataTable` and `IndexTable`. NOTE: the existing usage of `bg-secondary-experiment` is not likely seen visually, because header cells defined their background as `bg-subdued` and sit on top of the row with `bg-secondary-experiment`. Likely further improvement here, but this will combat the incorrect color from leaking through. ### How to 🎩 Validate that `DataTable` and `IndexTable` do not render row backgrounds with `secondary`, but with `subdued`. - Storybook - [DataTable](https://storybook.web.swap-table-secondary-with-subdued.matt-kubej.us.spin.dev/?path=/story/all-components-datatable--default&globals=polarisSummerEditions2023:true;polarisSummerEditions2023ShadowBevelOptOut:true) - [IndexTable](https://storybook.web.swap-table-secondary-with-subdued.matt-kubej.us.spin.dev/?path=/story/all-components-indextable--default&globals=polarisSummerEditions2023:true;polarisSummerEditions2023ShadowBevelOptOut:true) - Web - [Product Index](https://admin.web.swap-table-secondary-with-subdued.matt-kubej.us.spin.dev/store/shop1/products) (using snapshot and loaded with products to test sticky header) ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [x] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/Shopify/polaris-summer-editions/issues/262
Closes https://github.com/Shopify/polaris-summer-editions/issues/646
@shopify/polaris-migratorto swapbg-subduedandbg-secondaryinstancesbg-subduedandbg-secondaryedge cases (after each migration)Example
@shopify/polaris-migratorcommands:Example search after each migration:
VS Code search:
['"-]bg-subdued[^-]Files to include:
src/components/{Button,Card,LegacyCard,IndexTable,Tag,DataTable,KeyboardKey,Modal,ResourceList,Filters,LegacyFilters,Tabs,LegacyTabs}/**/*