This repository was archived by the owner on Sep 30, 2025. It is now read-only.
[Tab] Fix inconsistent border-radius #9543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aveline
approved these changes
Jun 27, 2023
sarahill
approved these changes
Jun 27, 2023
aaronccasanova
approved these changes
Jun 27, 2023
gwyneplaine
added
the
🤖Skip Changelog
5 tasks
ginabak
added a commit
that referenced
this pull request
Jul 6, 2023
## 📣 ❤️ Hey hey reviewers! 🥳 Would you mind looking at the `Questions` portion below? 🙏🏽 THANK YOU IN ADVANCE. ### WHY are these changes introduced? Following the **[Uplift Figma Link for `Tabs`](https://www.figma.com/file/jLLkmo9r28hiqPvf4s90E4/Polaris-Uplift-Components-%5Bgen3%E2%80%93alpha%5D?node-id=84001%3A38964&mode=dev)** 🖌️ , the background colour on `hover` and `active` should be ```CSS background: var(--background-bg-secondary, #F3F3F3); ``` Related #9543 Discovered through Shopify/web#96536 ### WHAT is this pull request doing? (with uplift) | Before | After | |--------|--------| | <img width="566" alt="Screenshot 2023-07-05 at 1 31 29 PM" src="https://github.com/Shopify/polaris/assets/43223543/41da1a18-6f19-4ece-af4d-bba8d5434316"> | <img width="566" alt="Screenshot 2023-07-05 at 1 32 34 PM" src="https://github.com/Shopify/polaris/assets/43223543/96c1239c-d63a-4cb1-a43e-6ddb2ae9cc9d"> | ### ❓ Questions 🙏🏽 1. I'm noticing that the `More views` font is slightly more bolded - is this what we want? I can't find any thing in the Figma 😄 <img width="250" alt="Screenshot 2023-07-05 at 1 59 53 PM" src="https://github.com/Shopify/polaris/assets/43223543/084499b4-aeff-4280-982b-e3d4780c234d"> 2. At a certain breakpoint, `More views` disappears, the tabs get slightly larger, and then a scroll appears. Is this the desired behaviour? I find it a little jarring. Here's a video: https://github.com/Shopify/polaris/assets/43223543/392582e0-6f59-4449-89b3-cde4a9a42429 ### How to 🎩 🎩 🌀 [SPIN on web with these changes 😄 - takes you to Orders ❤️ ](https://admin.web.more-views.gina-bak.us.spin.dev/store/shop1/orders?inContextTimeframe=none) 🌀 Ensure that you have a smaller window frame to ensure that the `More views` is triggered 😄 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes https://github.com/Shopify/polaris-summer-editions/issues/434 <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? Before:  After:  ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
## 📣 ❤️ Hey hey reviewers! 🥳 Would you mind looking at the `Questions` portion below? 🙏🏽 THANK YOU IN ADVANCE. ### WHY are these changes introduced? Following the **[Uplift Figma Link for `Tabs`](https://www.figma.com/file/jLLkmo9r28hiqPvf4s90E4/Polaris-Uplift-Components-%5Bgen3%E2%80%93alpha%5D?node-id=84001%3A38964&mode=dev)** 🖌️ , the background colour on `hover` and `active` should be ```CSS background: var(--background-bg-secondary, #F3F3F3); ``` Related Shopify#9543 Discovered through https://github.com/Shopify/web/issues/96536 ### WHAT is this pull request doing? (with uplift) | Before | After | |--------|--------| | <img width="566" alt="Screenshot 2023-07-05 at 1 31 29 PM" src="https://github.com/Shopify/polaris/assets/43223543/41da1a18-6f19-4ece-af4d-bba8d5434316"> | <img width="566" alt="Screenshot 2023-07-05 at 1 32 34 PM" src="https://github.com/Shopify/polaris/assets/43223543/96c1239c-d63a-4cb1-a43e-6ddb2ae9cc9d"> | ### ❓ Questions 🙏🏽 1. I'm noticing that the `More views` font is slightly more bolded - is this what we want? I can't find any thing in the Figma 😄 <img width="250" alt="Screenshot 2023-07-05 at 1 59 53 PM" src="https://github.com/Shopify/polaris/assets/43223543/084499b4-aeff-4280-982b-e3d4780c234d"> 2. At a certain breakpoint, `More views` disappears, the tabs get slightly larger, and then a scroll appears. Is this the desired behaviour? I find it a little jarring. Here's a video: https://github.com/Shopify/polaris/assets/43223543/392582e0-6f59-4449-89b3-cde4a9a42429 ### How to 🎩 🎩 🌀 [SPIN on web with these changes 😄 - takes you to Orders ❤️ ](https://admin.web.more-views.gina-bak.us.spin.dev/store/shop1/orders?inContextTimeframe=none) 🌀 Ensure that you have a smaller window frame to ensure that the `More views` is triggered 😄 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes Shopify/archive-polaris-backlog-2024#434 <!-- Context about the problem that’s being addressed. --> ### WHAT is this pull request doing? Before:  After:  ### How to 🎩 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) <!-- Give as much information as needed to experiment with the component in the playground. --> <details> <summary>Copy-paste this code in <code>playground/Playground.tsx</code>:</summary> ```jsx import React from 'react'; import {Page} from '../src'; export function Playground() { return ( <Page title="Playground"> {/* Add the code you want to test in here */} </Page> ); } ``` </details> ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [ ] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
ascherkus
pushed a commit
to ascherkus/polaris
that referenced
this pull request
Feb 19, 2025
## 📣 ❤️ Hey hey reviewers! 🥳 Would you mind looking at the `Questions` portion below? 🙏🏽 THANK YOU IN ADVANCE. ### WHY are these changes introduced? Following the **[Uplift Figma Link for `Tabs`](https://www.figma.com/file/jLLkmo9r28hiqPvf4s90E4/Polaris-Uplift-Components-%5Bgen3%E2%80%93alpha%5D?node-id=84001%3A38964&mode=dev)** 🖌️ , the background colour on `hover` and `active` should be ```CSS background: var(--background-bg-secondary, #F3F3F3); ``` Related Shopify#9543 Discovered through Shopify/web#96536 ### WHAT is this pull request doing? (with uplift) | Before | After | |--------|--------| | <img width="566" alt="Screenshot 2023-07-05 at 1 31 29 PM" src="https://github.com/Shopify/polaris/assets/43223543/41da1a18-6f19-4ece-af4d-bba8d5434316"> | <img width="566" alt="Screenshot 2023-07-05 at 1 32 34 PM" src="https://github.com/Shopify/polaris/assets/43223543/96c1239c-d63a-4cb1-a43e-6ddb2ae9cc9d"> | ### ❓ Questions 🙏🏽 1. I'm noticing that the `More views` font is slightly more bolded - is this what we want? I can't find any thing in the Figma 😄 <img width="250" alt="Screenshot 2023-07-05 at 1 59 53 PM" src="https://github.com/Shopify/polaris/assets/43223543/084499b4-aeff-4280-982b-e3d4780c234d"> 2. At a certain breakpoint, `More views` disappears, the tabs get slightly larger, and then a scroll appears. Is this the desired behaviour? I find it a little jarring. Here's a video: https://github.com/Shopify/polaris/assets/43223543/392582e0-6f59-4449-89b3-cde4a9a42429 ### How to 🎩 🎩 🌀 [SPIN on web with these changes 😄 - takes you to Orders ❤️ ](https://admin.web.more-views.gina-bak.us.spin.dev/store/shop1/orders?inContextTimeframe=none) 🌀 Ensure that you have a smaller window frame to ensure that the `More views` is triggered 😄 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes https://github.com/Shopify/polaris-summer-editions/issues/434
WHAT is this pull request doing?
Before:
After:
How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
Copy-paste this code in
playground/Playground.tsx:🎩 checklist
README.mdwith documentation changes