This repository was archived by the owner on Sep 30, 2025. It is now read-only.
[Modal] Fix content overflow / scroll bug #8018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyledurand
commented
Jan 10, 2023
kyledurand
changed the title
size-limit report 📦
|
kyledurand
commented
Jan 10, 2023
|
|
||
| const scrollContainerMarkup = noScroll ? ( | ||
| <Box width="100%">{body}</Box> | ||
| <Box width="100%" overflowX="hidden"> |
There was a problem hiding this comment.
kyledurand
force-pushed
the
modal_fix-no-scroll-behavior
branch
from
b5c7971 to
3e344ec
Compare
|
/snapit |
|
🫰✨ Thanks @kyledurand! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/plugin-polaris@0.0.0-snapshot-release-20230110211626yarn add @shopify/polaris-migrator@0.0.0-snapshot-release-20230110211626yarn add @shopify/polaris@0.0.0-snapshot-release-20230110211626yarn add @shopify/stylelint-polaris@0.0.0-snapshot-release-20230110211626 |
yurm04
approved these changes
Jan 10, 2023
There was a problem hiding this comment.
🚢 tested in a couple of spots with long form modals and looks good! thanks for jumping on this quickly @kyledurand
sarahill
reviewed
Jan 11, 2023
There was a problem hiding this comment.
I'm seeing one thing with the alignment of the buttons in the footer when overflow scroll is present. They're sitting a little lower and bleeding into the bottom padding. I'm only seeing this when there's overflow content.
Orders > Create order
Click on "Add custom item" or "Change market" and reduce height of browser if needed to force overflow scrolling
Merged
kyledurand
pushed a commit
that referenced
this pull request
Jan 11, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris@10.19.0 ### Minor Changes - [#7817](#7817) [`6c310101d`](6c31010) Thanks [@henryyi](https://github.com/henryyi)! - Added `secondaryActions` prop in Navigation.Item to support up to two actions ### Patch Changes - [#8018](#8018) [`2620b0a20`](2620b0a) Thanks [@kyledurand](https://github.com/kyledurand)! - Fixed modal scroll bug ## @shopify/stylelint-polaris@5.1.0 ### Minor Changes - [#7993](#7993) [`128f147d1`](128f147) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Created `polaris/declaration-property-value-disallowed-list` rule to ignore failures in `@font-face` at-rules ### Patch Changes - [#8006](#8006) [`6404b1638`](6404b16) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Temporarily disabled `border-radius-base` error ## @shopify/plugin-polaris@0.0.26 ### Patch Changes - Updated dependencies \[[`fad3809ef`](fad3809), [`56b0bc2dc`](56b0bc2)]: - @shopify/polaris-migrator@0.10.3 ## @shopify/polaris-migrator@0.10.3 ### Patch Changes - [#7997](#7997) [`fad3809ef`](fad3809) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Updated `styles-tokenize-font` to ignore `@font-face` at-rules - [#7783](#7783) [`56b0bc2dc`](56b0bc2) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Improve robustness of the `react-replace-text-components` migration - Updated dependencies \[[`6404b1638`](6404b16), [`128f147d1`](128f147)]: - @shopify/stylelint-polaris@5.1.0 ## polaris.shopify.com@0.28.3 ### Patch Changes - Updated dependencies \[[`2620b0a20`](2620b0a), [`6c310101d`](6c31010)]: - @shopify/polaris@10.19.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
5 tasks
kyledurand
added a commit
that referenced
this pull request
Jan 17, 2023
### WHY are these changes introduced? Fixes #8018 (review) [Spin link](https://admin.web.web-vtxq.kyle-durand.us.spin.dev/store/shop1) </details> ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Merged
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
Fixes: Shopify#8013 [Spin link](https://admin.web.billing-kmux.kyle-durand.us.spin.dev/store/shop1) The cause of this bug was not porting over `overflow-x: hidden` from the body markup container Before | After ---|---  | 
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris@10.19.0 ### Minor Changes - [Shopify#7817](Shopify#7817) [`6c310101d`](Shopify@6c31010) Thanks [@henryyi](https://github.com/henryyi)! - Added `secondaryActions` prop in Navigation.Item to support up to two actions ### Patch Changes - [Shopify#8018](Shopify#8018) [`2620b0a20`](Shopify@2620b0a) Thanks [@kyledurand](https://github.com/kyledurand)! - Fixed modal scroll bug ## @shopify/stylelint-polaris@5.1.0 ### Minor Changes - [Shopify#7993](Shopify#7993) [`128f147d1`](Shopify@128f147) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Created `polaris/declaration-property-value-disallowed-list` rule to ignore failures in `@font-face` at-rules ### Patch Changes - [Shopify#8006](Shopify#8006) [`6404b1638`](Shopify@6404b16) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Temporarily disabled `border-radius-base` error ## @shopify/plugin-polaris@0.0.26 ### Patch Changes - Updated dependencies \[[`fad3809ef`](Shopify@fad3809), [`56b0bc2dc`](Shopify@56b0bc2)]: - @shopify/polaris-migrator@0.10.3 ## @shopify/polaris-migrator@0.10.3 ### Patch Changes - [Shopify#7997](Shopify#7997) [`fad3809ef`](Shopify@fad3809) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Updated `styles-tokenize-font` to ignore `@font-face` at-rules - [Shopify#7783](Shopify#7783) [`56b0bc2dc`](Shopify@56b0bc2) Thanks [@aaronccasanova](https://github.com/aaronccasanova)! - Improve robustness of the `react-replace-text-components` migration - Updated dependencies \[[`6404b1638`](Shopify@6404b16), [`128f147d1`](Shopify@128f147)]: - @shopify/stylelint-polaris@5.1.0 ## polaris.shopify.com@0.28.3 ### Patch Changes - Updated dependencies \[[`2620b0a20`](Shopify@2620b0a), [`6c310101d`](Shopify@6c31010)]: - @shopify/polaris@10.19.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
### WHY are these changes introduced? Fixes Shopify#8018 (review) [Spin link](https://admin.web.web-vtxq.kyle-durand.us.spin.dev/store/shop1) </details> ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8013
Spin link
The cause of this bug was not porting over
overflow-x: hiddenfrom the body markup container