This repository was archived by the owner on Sep 30, 2025. It is now read-only.
[Modal] Fix vertical alignment in footer with noScroll #8040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyledurand
force-pushed
the
modal_fix-footer-layout-with-no-scroll
branch
from
d046dd3 to
1602be5
Compare
size-limit report 📦
|
|
/snapit |
|
🫰✨ Thanks @kyledurand! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/plugin-polaris@0.0.0-snapshot-release-20230112150520yarn add @shopify/polaris@0.0.0-snapshot-release-20230112150520 |
sarahill
approved these changes
Jan 12, 2023
kyledurand
force-pushed
the
modal_fix-footer-layout-with-no-scroll
branch
from
1602be5 to
e085042
Compare
Merged
mrcthms
pushed a commit
that referenced
this pull request
Jan 19, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-icons@6.8.0 ### Minor Changes - [#8049](#8049) [`dca31f2a0`](dca31f2) Thanks [@leileu](https://github.com/leileu)! - Added 8 minor icons for metafields - [#8069](#8069) [`f67e2997e`](f67e299) Thanks [@leileu](https://github.com/leileu)! - Added file minor icon - [#8063](#8063) [`d5da4778c`](d5da477) Thanks [@eric-blue](https://github.com/eric-blue)! - Added minor icon for diamond_alert - [#8037](#8037) [`1aeed2414`](1aeed24) Thanks [@dGoligorsky](https://github.com/dGoligorsky)! - Added major and minor icon for Magic ### Patch Changes - [#8085](#8085) [`56b757036`](56b7570) Thanks [@sarahill](https://github.com/sarahill)! - Added icon name for magic major and minor - [#8066](#8066) [`68acc4593`](68acc45) Thanks [@kyledurand](https://github.com/kyledurand)! - Added better error documentation on icon validation ## @shopify/polaris@10.22.0 ### Minor Changes - [#8054](#8054) [`c44c96c6b`](c44c96c) Thanks [@mrcthms](https://github.com/mrcthms)! - Update focus states to be present on :focus-visible rather than :focus ### Patch Changes - [#8080](#8080) [`1c926b9da`](1c926b9) Thanks [@LauraAubin](https://github.com/LauraAubin)! - Added an optional `zIndexOverride` prop to `Tooltip` - [#8077](#8077) [`dc2ed0a5c`](dc2ed0a) Thanks [@kyledurand](https://github.com/kyledurand)! - Removed data attribute css from legacy polyfill - [#8040](#8040) [`ba6b04c79`](ba6b04c) Thanks [@kyledurand](https://github.com/kyledurand)! - Fixed modal footer vertical alignment when noScroll is true - Updated dependencies \[[`dca31f2a0`](dca31f2), [`56b757036`](56b7570), [`f67e2997e`](f67e299), [`68acc4593`](68acc45), [`d5da4778c`](d5da477), [`1aeed2414`](1aeed24)]: - @shopify/polaris-icons@6.8.0 ## @shopify/plugin-polaris@0.0.29 ## polaris.shopify.com@0.29.0 ### Minor Changes - [#8027](#8027) [`8fc0fefdf`](8fc0fef) Thanks [@qt314](https://github.com/qt314)! - Add tooling section to document tools help build and maintain Polaris in consuming applications. ### Patch Changes - Updated dependencies \[[`dca31f2a0`](dca31f2), [`56b757036`](56b7570), [`f67e2997e`](f67e299), [`1c926b9da`](1c926b9), [`c44c96c6b`](c44c96c), [`dc2ed0a5c`](dc2ed0a), [`ba6b04c79`](ba6b04c), [`68acc4593`](68acc45), [`d5da4778c`](d5da477), [`1aeed2414`](1aeed24)]: - @shopify/polaris-icons@6.8.0 - @shopify/polaris@10.22.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Merged
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
### WHY are these changes introduced? Fixes Shopify#8018 (review) [Spin link](https://admin.web.web-vtxq.kyle-durand.us.spin.dev/store/shop1) </details> ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
juzser
pushed a commit
to juzser/polaris
that referenced
this pull request
Jul 27, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/polaris-icons@6.8.0 ### Minor Changes - [Shopify#8049](Shopify#8049) [`dca31f2a0`](Shopify@dca31f2) Thanks [@leileu](https://github.com/leileu)! - Added 8 minor icons for metafields - [Shopify#8069](Shopify#8069) [`f67e2997e`](Shopify@f67e299) Thanks [@leileu](https://github.com/leileu)! - Added file minor icon - [Shopify#8063](Shopify#8063) [`d5da4778c`](Shopify@d5da477) Thanks [@eric-blue](https://github.com/eric-blue)! - Added minor icon for diamond_alert - [Shopify#8037](Shopify#8037) [`1aeed2414`](Shopify@1aeed24) Thanks [@dGoligorsky](https://github.com/dGoligorsky)! - Added major and minor icon for Magic ### Patch Changes - [Shopify#8085](Shopify#8085) [`56b757036`](Shopify@56b7570) Thanks [@sarahill](https://github.com/sarahill)! - Added icon name for magic major and minor - [Shopify#8066](Shopify#8066) [`68acc4593`](Shopify@68acc45) Thanks [@kyledurand](https://github.com/kyledurand)! - Added better error documentation on icon validation ## @shopify/polaris@10.22.0 ### Minor Changes - [Shopify#8054](Shopify#8054) [`c44c96c6b`](Shopify@c44c96c) Thanks [@mrcthms](https://github.com/mrcthms)! - Update focus states to be present on :focus-visible rather than :focus ### Patch Changes - [Shopify#8080](Shopify#8080) [`1c926b9da`](Shopify@1c926b9) Thanks [@LauraAubin](https://github.com/LauraAubin)! - Added an optional `zIndexOverride` prop to `Tooltip` - [Shopify#8077](Shopify#8077) [`dc2ed0a5c`](Shopify@dc2ed0a) Thanks [@kyledurand](https://github.com/kyledurand)! - Removed data attribute css from legacy polyfill - [Shopify#8040](Shopify#8040) [`ba6b04c79`](Shopify@ba6b04c) Thanks [@kyledurand](https://github.com/kyledurand)! - Fixed modal footer vertical alignment when noScroll is true - Updated dependencies \[[`dca31f2a0`](Shopify@dca31f2), [`56b757036`](Shopify@56b7570), [`f67e2997e`](Shopify@f67e299), [`68acc4593`](Shopify@68acc45), [`d5da4778c`](Shopify@d5da477), [`1aeed2414`](Shopify@1aeed24)]: - @shopify/polaris-icons@6.8.0 ## @shopify/plugin-polaris@0.0.29 ## polaris.shopify.com@0.29.0 ### Minor Changes - [Shopify#8027](Shopify#8027) [`8fc0fefdf`](Shopify@8fc0fef) Thanks [@qt314](https://github.com/qt314)! - Add tooling section to document tools help build and maintain Polaris in consuming applications. ### Patch Changes - Updated dependencies \[[`dca31f2a0`](Shopify@dca31f2), [`56b757036`](Shopify@56b7570), [`f67e2997e`](Shopify@f67e299), [`1c926b9da`](Shopify@1c926b9), [`c44c96c6b`](Shopify@c44c96c), [`dc2ed0a5c`](Shopify@dc2ed0a), [`ba6b04c79`](Shopify@ba6b04c), [`68acc4593`](Shopify@68acc45), [`d5da4778c`](Shopify@d5da477), [`1aeed2414`](Shopify@1aeed24)]: - @shopify/polaris-icons@6.8.0 - @shopify/polaris@10.22.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #8018 (review)
Spin link
🎩 checklist
README.mdwith documentation changes