This repository was archived by the owner on Sep 30, 2025. It is now read-only.
[Tabs][Uplift]: Match hover and active colour #9619
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -133,12 +133,8 @@ | |
| } | ||
|
|
||
| &:not([aria-disabled='true']):hover { | ||
| background-color: var(--p-color-bg-secondary-experimental); | ||
| color: var(--p-color-text-primary); | ||
| } | ||
|
|
||
| &:not([aria-disabled='true']):focus-visible { | ||
|
|
@@ -149,13 +145,9 @@ | |
| } | ||
|
|
||
| &:not([aria-disabled='true']):active { | ||
| background-color: var(--p-color-bg-secondary-experimental); | ||
| color: var(--p-color-text-primary); | ||
| z-index: var(--p-z-index-1); | ||
|
There was a problem hiding this comment. |
||
| } | ||
|
|
||
| @media #{$p-breakpoints-md-up} { | ||
|
|
@@ -187,12 +179,9 @@ | |
| } | ||
|
|
||
| #{$se23} & { | ||
| background: var(--p-color-bg-secondary-experimental); | ||
| color: var(--p-color-text); | ||
| border-radius: var(--p-border-radius-2); | ||
|
|
||
| &[aria-disabled='true'] { | ||
| background: var(--p-color-bg-disabled); | ||
|
|
@@ -201,20 +190,12 @@ | |
|
|
||
| &:not([aria-disabled='true']):hover, | ||
| &:not([aria-disabled='true']):focus { | ||
| background-color: var(--p-color-bg-secondary-experimental); | ||
| color: var(--p-color-text-primary); | ||
| } | ||
|
|
||
| &:not([aria-disabled='true']):active { | ||
| background-color: var(--p-color-bg-secondary-experimental); | ||
| } | ||
| } | ||
| } | ||
|
|
@@ -374,7 +355,7 @@ | |
| } | ||
|
|
||
| &:not([aria-disabled='true']):hover { | ||
|
There was a problem hiding this comment. ℹ️ This is the only change in the PR (the others are cleanup 🧼 🧹). This is behind the and this follows the |
||
| background-color: var(--p-color-bg-secondary-experimental); | ||
| color: var(--p-color-text-primary); | ||
| } | ||
|
|
||
|
|
@@ -384,7 +365,7 @@ | |
| } | ||
|
|
||
| &:not([aria-disabled='true']):active { | ||
|
There was a problem hiding this comment. From the Uplift Figma for |
||
| background-color: var(--p-color-bg-secondary-experimental); | ||
| } | ||
| } | ||
| } | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already under the primary
#{$se23}and just needed to be cleaned up.https://github.com/Shopify/polaris/blob/5e2c3c532a9a0ee7aa6fd49439be118364a44c0d/polaris-react/src/components/Tabs/Tabs.scss#L123