Add semantic token for name in a method definition #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paracycle
approved these changes
Jun 7, 2022
vinistock
reviewed
Jun 7, 2022
| @encoder.encode(@tokens) | ||
| end | ||
|
|
||
| def visit_def(node) |
There was a problem hiding this comment.
Can we do singleton and endless definition methods too?
There was a problem hiding this comment.
Yes! Can that be in the next PR?
There was a problem hiding this comment.
PR for singleton and endless def: #134
vinistock
approved these changes
Jun 8, 2022
andyw8
referenced
this pull request
in andyw8/ruby-lsp
Mar 2, 2024
…mport-resolver-typescript-3.1.1 Bump eslint-import-resolver-typescript from 2.7.1 to 3.1.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Define a new semantic token for method names using the modifiers implemented in #112
Implementation
Similar to the previous semantic tokens, add a visit method for it.
Automated Tests
Most of the tests contain a method definition, which means an additional token is added to the array of expected tokens.
Manual Tests
Inspect Editor Token and Scope.