Add semantic token for constants #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
reviewed
Jun 9, 2022
| TOKEN_TYPES = [ | ||
| :variable, | ||
| :method, | ||
| :namespace, |
There was a problem hiding this comment.
Since we can't differentiate between a module and class reference, should we use namespace or class?
There was a problem hiding this comment.
I thought calling both modules and classes a class token may be confusing, and so settled with namespace. Any opinions?
There was a problem hiding this comment.
I just checked and all classes and modules are considered modules. So, indeed namespace would be the more appropriate one.
vinistock
approved these changes
Jun 9, 2022
wildmaples
force-pushed
the
sh-consistent-constants
branch
from
0d52ef7 to
64fa643
Compare
RyanBrushett
approved these changes
Jun 9, 2022
Morriar
approved these changes
Jun 9, 2022
|
|
||
| response = make_request("textDocument/semanticTokens/full", { textDocument: { uri: "file://#{__FILE__}" } }) | ||
| assert_empty(response[:result][:data]) | ||
| assert_equal([0, 6, 3, 2, 0], response[:result][:data]) |
There was a problem hiding this comment.
We should reconsider how we test this (in another PR) because this is surprisingly cryptic.
wildmaples
force-pushed
the
sh-consistent-constants
branch
from
64fa643 to
7ecb07f
Compare
This is an expected failure since the source code contains a constant.
wildmaples
force-pushed
the
sh-consistent-constants
branch
from
7ecb07f to
11dc40e
Compare
andyw8
referenced
this pull request
in andyw8/ruby-lsp
Mar 2, 2024
klaaspieter
pushed a commit
to klaaspieter/ruby-lsp
that referenced
this pull request
Feb 25, 2025
* Fix spacing between constants and sigs * Use HTTP response classes instead of code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Inconsistent highlighting in constants:
Implementation
Add new semantic token type,
namespace, and add them as a token for constants.Irrelevant to the primary issue but I also rearranged some of the visit methods in alphabetical order.
Automated Tests
const.expManual Tests
test/fixtures/const.rb