Use fully qualified names in document symbol #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paracycle
approved these changes
Jun 9, 2022
Morriar
approved these changes
Jun 10, 2022
vinistock
force-pushed
the
vs/use_fully_qualified_names_in_document_symbols
branch
from
e22a532 to
5fee78f
Compare
klaaspieter
pushed a commit
to klaaspieter/ruby-lsp
that referenced
this pull request
Feb 25, 2025
…p-minitest-0.31.1 Bump rubocop-minitest from 0.31.0 to 0.31.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #113
Use the fully qualified names for constants and modules when displaying document symbols. In relation to the alternative way of solving this issue (displaying the values nested), I think this provides a better experience as it follows the flow of the file.
Implementation
Created a helper method to find the fully qualified name of a
ClassDeclarationorModuleDeclarationnode. This recursively steps through each parent and builds the complete name.Automated Tests
Added a new fixture based on the example.
Manual Tests
test/fixtures/one_line_nesting.rb