Minimize semantic tokens returned for local variables #2482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
enhancement
vinistock
force-pushed
the
vs-minimize-local-var-tokens
branch
from
3d2af6b to
4cefb4d
Compare
st0012
reviewed
Aug 23, 2024
st0012
added
the
vscode
st0012
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Similar to #2479, this PR minimizes the number of semantic tokens returned to the editor for local variables.
We don't need to return semantic tokens for most local variable assignments, because they can be detected with Text Mate grammars.
Implementation
In the grammar, I added rules for local variable assignments. In the server, I removed handling of local variable assignments. We still need to handle local variable read, to differentiate between parameters and local variables.
Automated Tests
Updated the expectations.