Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't lose search params on profiling #52

Merged
merged 2 commits into from
Apr 23, 2020
Merged

Don't lose search params on profiling #52

merged 2 commits into from
Apr 23, 2020

Conversation

wizardlyhel
Copy link
Contributor

What issue does this pull request address?

A theme can have alternate views which is accessible by <store_url>?view=alternate when a index.alternate.liquid exists in the theme bundle

What is the solution

Make sure the profiling url includes the search param from the url

@wizardlyhel wizardlyhel requested a review from max611 April 23, 2020 17:27
max611
max611 approved these changes Apr 23, 2020
View reviewed changes
Copy link
Member

@max611 max611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@wizardlyhel wizardlyhel merged commit 72e855e into master Apr 23, 2020
@wizardlyhel wizardlyhel deleted the add-search-param branch April 23, 2020 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max611 max611 max611 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wizardlyhel @max611