Skip to content
This repository has been archived by the owner on Jul 19, 2021. It is now read-only.

1.x - (slate-tools 1.0.0-alpha.26) Asset references using asset_url leads to incorrect url in Local Dev #460

Closed
rg-najera opened this issue Mar 29, 2018 · 5 comments
Assignees

Comments

@rg-najera
Copy link

rg-najera commented Mar 29, 2018

Problem

Using asset_url leads local dev asset path to include default shopify CDN because the dist file processed still contains a liquid variable that is then processed by the liquid engine.

Replication steps

Using the following:

<img src="{{ '../assets/svg/hero_title.svg' | asset_url }}" class="lazyload js"/>

Result:

<img src="//cdn.shopify.com/s/files/1/2643/4686/t/2/assets/https://localhost:8080/hero_title.svg?16805492649583399412" class="js lazyloaded">

Instead of

<img src="https://localhost:8080/hero_title.svg" class="js lazyloaded">

More Information

I recommend striping the tag altogether and printing a local version for dev
<img src="'https://localhost:8080/hero_title.svg' " class="lazyload js"/>

Using slate-tools 1.0.0-alpha.26

Referenced in #407

@rg-najera rg-najera changed the title 1.x - Asset references using asset_url leads to wrong url in Local Dev 1.x - Asset references using asset_url leads to incorrect url in Local Dev Mar 29, 2018
@rg-najera rg-najera changed the title 1.x - Asset references using asset_url leads to incorrect url in Local Dev 1.x - (slate-tools 1.0.0-alpha.26) Asset references using asset_url leads to incorrect url in Local Dev Mar 29, 2018
@seandogg
Copy link

Same here +1

@t-kelly
Copy link
Contributor

t-kelly commented Mar 30, 2018

Related #409

Will take a look at this first thing next week. Thanks for creating an issue!

@t-kelly t-kelly self-assigned this Mar 30, 2018
@et1421
Copy link

et1421 commented Apr 16, 2018

Any news on when this issue will be fixed ?

@t-kelly
Copy link
Contributor

t-kelly commented Apr 25, 2018

Fixed. Will release in next version.

@t-kelly t-kelly closed this as completed Apr 25, 2018
@lock
Copy link

lock bot commented Oct 26, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants