Unable to include assets from external app v1.x

[et1421]

Possibly related: #409 #410

Problem

One app installed in my store (Multi Currency) needs to import some assets inside its snippets files.

But the dist folder seems to be deleted at the moment of compilation. Therefore, the liquid compilation crashes because the asset is inexistant.

The only way to deploy is to put the local link on build (http://localhost:8080/bold-currency-bootstrap.js), and then to go and change the URLs inside Shopify admin.

Replication steps

For example :
<script src="{{ 'bold-currency-bootstrap.js' | asset_url }}" defer></script>
ound bold-currency-converter.liquid snippet crashes the build process.

[t-kelly]

Hey @et1421! Could you try throwing whatever asset you need into the src/assets/vendors folder? We're currently copying any contents of that folder directly into the dist/assets. Does that work?

[et1421]

The assets are in the src/assets/vendors folder and are copied inside the dist/assets, this part is working for the watch task, but on compilation an error is thrown (same problem as #408 )

Failed to compile.

undefined
Error in ./snippets/bold-currency-converter.liquid
Module not found: Can't resolve './bold-currency-bootstrap.js' in '/Applications/MAMP/htdocs//src/snippets'

@ multi ../node_modules/@shopify/slate-tools/tools/webpack/hot-client.js ../node_modules/@shopify/slate-tools/tools/webpack/static-files-glob.js

Compiled with warnings.

Warning in ./snippets/bold-currency-converter.liquid
Module build failed: ModuleNotFoundError: Module not found: Error: Can't resolve './bold-currency-bootstrap.js' in '/Applications/MAMP/htdocs//src/snippets'
@ . sync ^./snippets.*.liquid$
@ ../node_modules/@shopify/slate-tools/tools/webpack/static-files-glob.js
@ multi ../node_modules/@shopify/slate-tools/tools/webpack/hot-client.js ../node_modules/@shopify/slate-tools/tools/webpack/static-files-glob.js

but with the deploy task, a different problem occurs. I have about the same error (Module build failed: ModuleNotFoundError: Module not found: Error: Can't resolve './bold-currency-bootstrap.js' in '/Applications/MAMP/htdocs/<project-name>/src/snippets'), except at the moment the build crashes, there is no dist folder in the projet, because it has been deleted by the build process.

[pfcodes]

Any update on this?

[numediaweb]

I think if you want to reference static files you shoud use:
""
instead of
''
see: #407 (comment)

[t-kelly]

Assets have been simplified in #850 and the change is now available in v1.0.0-beta.12

Docs that have also been updated:

• https://github.com/Shopify/slate/wiki/Slate-themes
• https://github.com/Shopify/slate/wiki/Template-and-layout-bundles
• https://github.com/Shopify/slate/wiki/Local-development

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.