Fix lax checking of filename against genericTemplateName in sections plugin

[andyexeter]

The sections plugin was performing a lax check on the section filename against the genericTemplateName option, using the includes() method to see if the relativePathFromSections argument includes the genericTemplateName option value anywhere within it.

This meant files such as src/sections/collection-template.liquid were compiled to dist/sections/collection-template.liquid.liquid and were not being updated on Shopify when changes were made locally with yarn start running.

This fix compares the basename of the relativePathFromSections argument instead.

Checklist

For contributors:

• I have updated the docs to reflect these changes, if applicable.

For maintainers:

• I have 🎩'd these changes.

[andyexeter]

I've signed the CLA - not sure what I need to do to get the check to run again.

[bertiful]

Thanks for your PR @andyexeter :)

[Maurice-JB]

Just checking -- what is the status of this PR? I can see it's been merged into Master but running
yarn upgrade --latest @shopify/slate-tools
doesn't seem to update the package.json or update any dependencies...

[wizardlyhel]

@Maurice-JB Working on it (This week). I'm fiddling with auto deploy configurations.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.