This repository has been archived by the owner on Jul 19, 2021. It is now read-only.
Update for accessible payment icons #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanPJF
suggested changes
May 16, 2017
There was a problem hiding this comment.
Nice! Though I feel we should be putting another hidden span before the <ul> saying something to the effect:
<span class="visually-hidden">Payment methods accepted</span>
Otherwise the site is just randomly saying the name of payment types.
Note: This will need a locale translation.
|
Sweet, I like the idea - I added the changes based on your feedback. |
t-kelly
approved these changes
May 19, 2017
NathanPJF
approved these changes
May 22, 2017
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish with this PR?
Fixes #86. The output for the payment icons in the footer now look like: