This repository has been archived by the owner on Jul 19, 2021. It is now read-only.
Fix typo and variable declaration order in product.js #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nitialized before using it in options object. - line 59, scripts/sections/product.js, this.$featured_image is not a defined variable (it's a typo), needs to be replaced with this.$featuredImage
t-kelly
changed the title
|
Good catch. Thanks! Will deploy a patch release now. |
|
sweet! |
|
The same typo as on line 59 can be found on line 127 as well: |
|
@sebpettersson on it! |
This was referenced Sep 6, 2017
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scripts/sections/product.js, this.productSingleObject needs to be initialized before using it in options object.
line 59, scripts/sections/product.js, this.$featured_image is not a defined variable (it's a typo), needs to be replaced with this.$featuredImage
What are you trying to accomplish with this PR?
Some basic fixes in scripts/sections/product.js
Please provide a link to the associated GitHub issue.
Checklist
For contributors:
For maintainers: