This repository has been archived by the owner on Jul 19, 2021. It is now read-only.
Display the gift card's initial value #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-kelly
suggested changes
Sep 18, 2017
|
|
||
| {% if gift_card.balance != gift_card.initial_value %} | ||
| <p>{{ 'gift_cards.issued.remaining_html' | t: balance: gift_card.balance | money }}</p> | ||
| <p>Current balance: {{ 'gift_cards.issued.remaining_html' | t: balance: gift_card.balance | money }}</p> |
There was a problem hiding this comment.
Actually this should be included in a locale, not hard-coded.
| <h2>{{ formatted_initial_value }}</h2> | ||
| {% assign formatted_initial_value = gift_card.initial_value | money_without_trailing_zeros: gift_card.currency %} | ||
|
|
||
| <h2>Gift card value: {{ formatted_initial_value }}</h2> |
t-kelly
approved these changes
Sep 19, 2017
bertiful
approved these changes
Sep 20, 2017
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish with this PR?
Always display the gift card's initial value, which currently never shows up. The only value that appears is the card's balance, and that only appears when when it's not equal to the card's initial value. This should fix a comment posted on issue #279. (fix #279)
Checklist