Skip to content
This repository has been archived by the owner on Jul 19, 2021. It is now read-only.

Add tests for cssnano config item #738

Merged
merged 1 commit into from
Sep 10, 2018
Merged

Add tests for cssnano config item #738

merged 1 commit into from
Sep 10, 2018

Conversation

t-kelly
Copy link
Contributor

@t-kelly t-kelly commented Sep 10, 2018

What are you trying to accomplish with this PR?

Followup to #737

  • Adds test for 'webpack.cssnano.settings' which makes sure the config is passed to cssnano
  • Isolates the sass rule for webpack in its own file to make it easier to test

@t-kelly t-kelly self-assigned this Sep 10, 2018
@t-kelly t-kelly merged commit 940d08c into master Sep 10, 2018
@t-kelly t-kelly deleted the cssnano-tests branch September 10, 2018 18:43
@t-kelly t-kelly mentioned this pull request Sep 10, 2018
Merged
@lock
Copy link

lock bot commented Oct 26, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@t-kelly t-kelly

Labels
internal v1.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@t-kelly