Skip to content
This repository has been archived by the owner on Jul 19, 2021. It is now read-only.

Add 'webpack.babel.exclude' config #755

Merged
merged 1 commit into from
Sep 14, 2018
Merged

Conversation

t-kelly
Copy link
Contributor

@t-kelly t-kelly commented Sep 14, 2018

What are you trying to accomplish with this PR?

Fixes #705

  • Add 'webpack.babel.exclude' config which defaults to the same value as 'webpack.commonExcludes'. This value can be modified by slate.config.js so that it includes a pattern that does not omit certain node_modules, e.g. /node_modules\/(?!(MY-MODULE|ANOTHER-ONE)\/).*/.
  • Refactor tests to mock fs.existsSync() instead of using mock-fs for mocking a .babelrc file.
  • Add test for 'webpack.babel.exclude'
  • Stylistic refactor of webpack/config/parts/babel.js
  • Replace commonExcludes() method with direct use of the 'webpack.commonExcludes' config.

@t-kelly t-kelly merged commit 52f0bb1 into master Sep 14, 2018
@t-kelly t-kelly deleted the add-babel-excludes-config branch September 14, 2018 13:29
@lock
Copy link

lock bot commented Oct 26, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant