Skip to content
This repository has been archived by the owner on Jul 19, 2021. It is now read-only.

Resolve Windows Slashes for styles and script tags snippets. #967

Merged
merged 1 commit into from
Feb 11, 2019
Merged

Resolve Windows Slashes for styles and script tags snippets. #967

merged 1 commit into from
Feb 11, 2019

Conversation

YourWishes
Copy link
Contributor

@YourWishes YourWishes commented Jan 31, 2019

What are you trying to accomplish with this PR?

Resolves #966

Added extra check for Windows Slashes in the script and style tags snippet template.

@ghost ghost added the cla-needed label Jan 31, 2019
@YourWishes YourWishes changed the title Resolve Windows Slashes for styles and script tags snippets Resolve Windows Slashes for styles and script tags snippets. Jan 31, 2019
@YourWishes YourWishes closed this Jan 31, 2019
@YourWishes YourWishes reopened this Jan 31, 2019
@YourWishes
Copy link
Contributor Author

Woops, gone ahead and signed the CLA, not sure if I can re-trigger the bot to check my status again.

@ghost ghost removed the cla-needed label Feb 11, 2019
@t-kelly t-kelly merged commit e1b372f into Shopify:master Feb 11, 2019
@t-kelly
Copy link
Contributor

t-kelly commented Feb 11, 2019

Thanks for the fix!

@lock
Copy link

lock bot commented Mar 13, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Mar 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants