The design #1

Shougo · 2017-12-07T02:38:55Z

Not depends on denite.nvim
Vim8/neovim compatible(nvim-yarp is needed for Vim8)
Implemented by Python3
No double filer feature
Column feature
Source feature
Options
Highlight is defined by column
Few commands (:Defx command only?)
Extended rename
Mark
Windows supporters are needed
The original trashbox feature
No minimal features
Subtree feature like vimfiler
No default mappings
No global variables
No explorer feature(like g:vimfiler_as_default_explorer)

Release date: In 2018 someday

The text was updated successfully, but these errors were encountered:

petobens · 2017-12-08T14:47:51Z

I think the double filer feature is really useful (i use it a lot). Also it would be nice to keep vimfiler's bookmark feature.

wsdjeg · 2017-12-08T15:01:30Z

@Shougo nice work,

@petobens what is double filer feature?

kirin123kirin · 2017-12-10T06:20:48Z

@Shougo
待ってました。
いつ頃リリース予定ですか？

kutsan · 2017-12-10T17:49:32Z

@kirin123kirin According to my Google Translate, I am also wondering when will it be released.

kirin123kirin · 2017-12-10T23:16:37Z

Can I open UNC Path for windows platform.

Shougo · 2017-12-11T06:18:30Z

I think the double filer feature is really useful (i use it a lot). Also it would be nice to keep vimfiler's bookmark feature.

It is useful. But I think jump/mark feature is better.
bookmark feature is to be determined.

Shougo · 2017-12-11T06:19:18Z

@petobens what is double filer feature?

:VimFilerDouble

You can copy/move the files to another vimfiler directory.

Shougo · 2017-12-11T06:26:19Z

Can I open UNC Path for windows platform.

The support is very hard.
I don't want to support it. You can add it though.

Please see:
Shougo/vimfiler.vim#170

Shougo · 2017-12-11T06:26:47Z

@kirin123kirin The release will be in 2018 someday.

Shougo · 2018-01-11T08:40:37Z

Column feature

Column means, "name", "type", "size", "date" should be customize-able more generic.
Users can add more columns like "git" column.

lambdalisue · 2018-01-15T15:26:29Z

It would be nice if it does not rely on filesystem.

For example, I would like to make a plugin which cooperate with this one to show a directory tree on a particular commit.
In that case, probably the INPUT for this plugin would be a tree dictionary with custom kind, actions, etc.

Shougo · 2018-01-16T02:51:19Z

It is already todo listed.

Source feature

Shougo · 2018-01-17T02:12:56Z

The source feature is similar to denite source.
But it is not compatible.

Shougo · 2018-01-21T05:27:27Z

I have started the vaporware development.

4b4dfae

kutsan · 2018-02-16T23:43:27Z

@Shougo Is there any way to set colors of items in the tree explorer according to $LS_COLORS env. variable (a.k.a. dircolors)?

Will you provide an API for vim-devicons symbols? Showing symbols on the right side of the explorer wasn't right choice. They should be just before the filename.

Shougo · 2018-02-18T08:49:49Z

@Shougo Is there any way to set colors of items in the tree explorer according to $LS_COLORS env. variable (a.k.a. dircolors)?

No.

Will you provide an API for vim-devicons symbols? Showing symbols on the right side of the explorer wasn't right choice. They should be just before the filename.

Yes. The column feature will be improved than vimfiler.

Shougo · 2018-02-28T06:44:27Z

I have decided defx has no default mappings and no global variables.

Shougo · 2018-02-28T06:45:54Z

defx.nvim does not support explorer feature like g:vimfiler_as_default_explorer.

It is very buggy and hard to implement.

amikai · 2018-07-19T06:08:14Z

I think the design can work like "file manager". Anything file related feature can be supported, not just explorer.
My suggestion is:
Inspire by Vscode.
Implement the special window which manages number of buffers.
The default buffer in this window is file explorer(like vscode).
The second buffer maybe is git related information(like vscode).
Then other buffer can be implemented by who they want other feature.

Shougo · 2018-07-30T14:14:43Z

I have re-started defx.nvim development.
You can test it.

Note: Current defx.nvim is neovim only.

amikai · 2018-07-31T10:30:20Z

What does toggle_select do?

Shougo · 2018-07-31T23:45:06Z

What does toggle_select do?

It changes candidate select state.
It same with denite.

kristijanhusak · 2018-08-28T13:11:44Z

@Shougo , when will custom column feature be available?

Shougo · 2018-08-29T00:08:21Z

It takes more time.

More default columns
Multiple buffers support
Split defx buffer
Copy, Move

Above features are hipriority than column customization.

kristijanhusak · 2018-08-29T06:01:15Z

Would you like to have git status column as part of the default columns? I have initial version of it.

Shougo · 2018-08-29T23:48:38Z

Would you like to have git status column as part of the default columns?

No.

Shougo · 2018-09-17T10:55:55Z

Copy, Move

Implemented.

oblitum · 2018-11-15T17:44:49Z

Is it in the plan to remove the yarp solution for supporting Vim? Having to depend on NeoVim for Vim to work isn't great.

oblitum · 2018-11-23T07:45:44Z

@Shougo thx!

oblitum · 2018-11-23T07:49:55Z

@Shougo defx#do_action('open_directory') is still opening files too though. I just tried.

Shougo · 2018-11-23T08:49:26Z

Fixed.

oblitum · 2018-11-23T08:52:59Z

Working :)

pwntester · 2018-12-03T09:11:32Z

Can you make open_directory similar to open in that it takes an optional argument with the directory path. I want to implement a custom action and need to receive the selected directory name and it should not trigger on regular files.

Thanks!

Shougo · 2018-12-03T13:56:10Z

I don't understand.
Please upload the example.

pwntester · 2018-12-03T16:16:08Z

I was trying to enable a mapping in the defx windows that when used on a directory, will run a command that takes the directory path as an argument.

For example, if I enter / on the /tmp/foo directory, I want to run: call esearch#init({'cwd': '/tmp/foo'})

Shougo · 2018-12-03T23:51:56Z

OK. I get it.
Please create the new issue for it.

pwntester · 2018-12-04T10:34:44Z

Thanks, filed #51

swnakamura · 2018-12-11T17:06:39Z

The time/date a directory is modified is not shown even when time option is enabled.
Is it an intentional design to hide the modification time of directories?

swnakamura · 2018-12-11T20:00:44Z

Also, when I do :Defx with unsaved file, the unsaved changes are discarded.
I think it would be better if we have something like --force option?

swnakamura · 2018-12-11T21:00:39Z

The time/date a directory is modified is not shown even when time option is enabled.
Is it an intentional design to hide the modification time of directories?

I made a PR to it. If you don't like it, please discard.
#53

Shougo · 2018-12-11T23:08:29Z

Also, when I do :Defx with unsaved file, the unsaved changes are discarded.
I think it would be better if we have something like --force option?

Please create the new issue for it. I will test it later.
If not, I will ignore your issue.

swnakamura · 2018-12-12T05:39:28Z

@Shougo Thank you! I created new issue #55 and start working on it :)

oblitum · 2018-12-17T06:48:10Z

Mouse support, good to have? VimFiler had I think.

kristijanhusak · 2018-12-17T09:05:50Z

You can add mouse support yourself if you want:

nnoremap <silent><buffer><expr> <2-LeftMouse> defx#do_action('drop')

Shougo · 2018-12-17T09:29:46Z

Yes. @kristijanhusak is right.

oblitum · 2018-12-17T16:27:15Z

@kristijanhusak @Shougo nice, thanks!

oblitum · 2018-12-17T16:47:12Z

My recommendation:

  nnoremap <silent><buffer><expr> <2-LeftMouse> defx#do_action('drop')
  nnoremap <silent><buffer><expr> <RightMouse> defx#do_action('cd', ['..'])

oblitum · 2018-12-21T03:23:05Z

Someone just asked on #vim whether there's a file browser that supports <c-i> and <c-o>, it seemed like netrw did not. I ignore one but, thought it would be food for thought here. The usecase was the person liked to go back to file browser after opening a buffer. Another usecase I think would be for directory navigation as a whole, would be nice <c-i>/<c-o> working at that.

oblitum · 2018-12-21T03:50:43Z

Seems dirvish supports that.

wsdjeg · 2018-12-22T07:21:21Z

The <c-i> and <C-o> in file manager buffer should not same as general vim key binding, because the origin feature of <C-i> and <c-o> is jump whthin current windows, but I do not think people like to use file manager tree in code buffer. But the feature, jump backward and forward shoudl works only in file tree buffer, that means, I use jump to last opened file position in file tree buffer.

…

________________________________ wsdjeg@outlook.com From: Francisco Lopes<mailto:notifications@github.com> Date: 2018-12-21 11:50 To: Shougo/defx.nvim<mailto:defx.nvim@noreply.github.com> CC: Wang Shidong<mailto:wsdjeg@outlook.com>; Comment<mailto:comment@noreply.github.com> Subject: Re: [Shougo/defx.nvim] The design (#1) Seems dirvish supports that. — You are receiving this because you commented. Reply to this email directly, view it on GitHub<#1 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AMiJkg2OXfqkD7crv6oFvF8Q_goXAIXfks5u7FqUgaJpZM4Q4551>.

Shougo · 2018-12-24T15:04:12Z

@oblitum I don't add the feature. Yes, dirvish already supports the feature. But some feature don't like it. I also don't like it.

Please see below issue.
justinmk/vim-dirvish#110

petobens · 2019-01-02T05:28:00Z

bookmark feature is to be determined.

@Shougo do you plan to add integrations with https://github.com/kmnk/denite-dirmark? I think that a good file manager should have a bookmarks feature.

Shougo · 2019-01-02T14:24:17Z

@petobens Nothing. But you can request it to the author.

Shougo · 2019-01-02T14:26:05Z

I think that a good file manager should have a bookmarks feature.

I have not much time to implement bookmark feature in defx.

petobens · 2019-01-02T14:37:40Z

Ok thanks. I did this here kmnk/denite-dirmark#2

Shougo mentioned this issue Dec 7, 2017

Denite Compatibility Shougo/vimfiler.vim#380

Closed

Shougo added the enhancement label Jan 24, 2018

pwntester mentioned this issue Dec 4, 2018

Implement custom actions #51

Closed

Shougo closed this as completed Feb 17, 2019

oblitum mentioned this issue May 1, 2019

Broken highlighting when path contains special chars #126

Closed

The design #1

The design #1

Comments

Shougo commented Dec 7, 2017 • edited Loading

petobens commented Dec 8, 2017

wsdjeg commented Dec 8, 2017

kirin123kirin commented Dec 10, 2017

kutsan commented Dec 10, 2017

kirin123kirin commented Dec 10, 2017

Shougo commented Dec 11, 2017

Shougo commented Dec 11, 2017

Shougo commented Dec 11, 2017

Shougo commented Dec 11, 2017

Shougo commented Jan 11, 2018

lambdalisue commented Jan 15, 2018

Shougo commented Jan 16, 2018

Shougo commented Jan 17, 2018

Shougo commented Jan 21, 2018

kutsan commented Feb 16, 2018 • edited Loading

Shougo commented Feb 18, 2018

Shougo commented Feb 28, 2018

Shougo commented Feb 28, 2018

amikai commented Jul 19, 2018

Shougo commented Jul 30, 2018

amikai commented Jul 31, 2018 • edited Loading

Shougo commented Jul 31, 2018

kristijanhusak commented Aug 28, 2018

Shougo commented Aug 29, 2018

kristijanhusak commented Aug 29, 2018

Shougo commented Aug 29, 2018

Shougo commented Sep 17, 2018

oblitum commented Nov 15, 2018

oblitum commented Nov 23, 2018

oblitum commented Nov 23, 2018

Shougo commented Nov 23, 2018

oblitum commented Nov 23, 2018

pwntester commented Dec 3, 2018

Shougo commented Dec 3, 2018

pwntester commented Dec 3, 2018

Shougo commented Dec 3, 2018

pwntester commented Dec 4, 2018

swnakamura commented Dec 11, 2018

swnakamura commented Dec 11, 2018

swnakamura commented Dec 11, 2018 • edited Loading

Shougo commented Dec 11, 2018

swnakamura commented Dec 12, 2018

oblitum commented Dec 17, 2018

kristijanhusak commented Dec 17, 2018

Shougo commented Dec 17, 2018

oblitum commented Dec 17, 2018

oblitum commented Dec 17, 2018

oblitum commented Dec 21, 2018

oblitum commented Dec 21, 2018

wsdjeg commented Dec 22, 2018 via email

Shougo commented Dec 24, 2018

petobens commented Jan 2, 2019

Shougo commented Jan 2, 2019

Shougo commented Jan 2, 2019

petobens commented Jan 2, 2019

Shougo commented Dec 7, 2017 •

edited

Loading

kutsan commented Feb 16, 2018 •

edited

Loading

amikai commented Jul 31, 2018 •

edited

Loading

swnakamura commented Dec 11, 2018 •

edited

Loading