WIP: Support neovim-prompt to improve denite prompt a lot! #40
Conversation
git-subtree-dir: rplugin/python3/denite/prompt git-subtree-split: c64c37f
…ython3/denite/prompt'
|
|
||
| @text.setter | ||
| def text(self, value): | ||
| self._context['input'] = value |
There was a problem hiding this comment.
Check insert mode here? But context should not aware the bridge instance...
|
|
||
|
|
||
| class BridgeContext(Context): | ||
| __slots__ = ('caret_locus', '_context') |
There was a problem hiding this comment.
Saving an entire _context is a bit too much. Context should hold a minimum information to restore the status to reduce the memory usage. But...
| @@ -9,7 +9,7 @@ | |||
|
|
|||
| if not find_loader('vim'): | |||
| import neovim | |||
| from denite.ui.default import Default | |||
| from denite.ui.bridge import Bridge | |||
There was a problem hiding this comment.
I think this might be changed in future release because denite will have custom UI support. That said, should neovim-prompt be a separate package rather built into denite core?
There was a problem hiding this comment.
Oops. Sorry I should have said that the new implementation will be an official UI while Shougo want to focus to produce more denite specific features and he don't want to pay attention to develop prompt part of the denite (at least for now).
|
I close this and re-open a new one. |
I'm making a general purpose customizable prompt in python, called neovim-prompt. The project is mainly for lista.nvim but we would like to use that in denite as well while the project supports
<C-a><C-b>, but a bit different format with the current one)<C-K><C-V>So denite would be more flexible and powerful with neovim-prompt 👍
This is WIP so it won't work but you can feel the flavour of the prompt 😄
I made this PR before I finished the work while I tried to keep existing code as much as possible so the implementation become a bit tricky.
So I would like to ask that if I should perform some refactoring to entire denite code as well to migrate neovim-prompt well or just make a bridge class like now?
Anyway we need some discussion about how should I implement the feature.
ToDo
<C-G>or whatever)