Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore AS Paths with single AS and remove all relevant cases #101

Merged
merged 1 commit into from
Nov 18, 2023
Merged

Ignore AS Paths with single AS and remove all relevant cases #101

merged 1 commit into from
Nov 18, 2023

Conversation

SichangHe
Copy link
Owner

Fix #100.

@SichangHe SichangHe requested a review from cunha November 16, 2023 04:41
@SichangHe
Copy link
Owner Author

@cunha, does this seem to match our discussion?

@SichangHe
Copy link
Owner Author

This causes very little difference for figures in #75, #90, #92.

as_stats2.csv

@SichangHe
Copy link
Owner Author

This also causes very little difference for figures in #96, #97, #98. A small decrease in unrecorded cases and increase in errors.

as_pair_stats2.csv.gz

@SichangHe
Copy link
Owner Author

This also causes very little difference for figures in #88, #91, #93, #99. Only 9084 routes turned out to be single-AS.

route_stats2.csv.gz

@SichangHe SichangHe merged commit 5429976 into main Nov 18, 2023
3 checks passed
@SichangHe
Copy link
Owner Author

SichangHe commented Nov 19, 2023 •
edited
Loading

Also little difference on #60 or #95.

as_neighbors_vs_rules3.csv

@SichangHe SichangHe mentioned this pull request Nov 23, 2023
Open
@SichangHe SichangHe mentioned this pull request Jan 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cunha cunha Awaiting requested review from cunha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should we check single export against the collector peer as peering
1 participant
@SichangHe