Skip to content

(For David) Pass config down from open #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 24, 2018
Merged

(For David) Pass config down from open #57

merged 6 commits into from
May 24, 2018

Conversation

garylee1
Copy link
Contributor

@garylee1 garylee1 commented May 22, 2018 •
edited
Loading

Passes down the config in open to the instance. Also makes any non-null open config take precedence over the archive. Addresses #55

@garylee1 garylee1 requested a review from ehrmann May 22, 2018 19:56
@ehrmann
Copy link
Contributor

ehrmann commented May 24, 2018

lgtm

@ehrmann ehrmann closed this May 24, 2018
@ehrmann ehrmann reopened this May 24, 2018
@garylee1 garylee1 merged commit f8fbd67 into master May 24, 2018
@ehrmann ehrmann deleted the gary_simpler_config branch May 2, 2019 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@ehrmann ehrmann ehrmann approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@garylee1 @ehrmann