Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Metrics Query Builder #1166

Merged

Conversation

pranshuchittora
Copy link
Contributor

No description provided.

@request-info
Copy link

request-info bot commented May 19, 2022

We would appreciate it if you could provide us with more info about this issue/pr!

feat: tag key selection

feat: metrics builder
@pranshuchittora pranshuchittora force-pushed the pranshuchittora/feat/metrics-builder branch from 6643a5c to 789a740 Compare May 25, 2022 07:34
@hankveal181

This comment was marked as off-topic.

@srikanthccv
Copy link
Member

@pranshuchittora add this patch. Show tag values as they come for the reasons discussed here.

diff --git a/frontend/src/container/NewWidget/LeftContainer/QuerySection/QueryBuilder/queryBuilder/MetricTagKeyFilter/utils.ts b/frontend/src/container/NewWidget/LeftContainer/QuerySection/QueryBuilder/queryBuilder/MetricTagKeyFilter/utils.ts
index 1ea5bfad..d50c6d64 100644
--- a/frontend/src/container/NewWidget/LeftContainer/QuerySection/QueryBuilder/queryBuilder/MetricTagKeyFilter/utils.ts
+++ b/frontend/src/container/NewWidget/LeftContainer/QuerySection/QueryBuilder/queryBuilder/MetricTagKeyFilter/utils.ts
@@ -34,7 +34,7 @@ export const GetTagValues = async (
        if (!payload || !payload?.data) {
                return [];
        }
-       return payload.data.filter(Boolean).map((tagValue: string) => ({
+       return payload.data.map((tagValue: string) => ({
                label: tagValue,
                value: tagValue,
        }));
diff --git a/frontend/src/types/common/dashboard.ts b/frontend/src/types/common/dashboard.ts
index 13e45d45..45ced7b5 100644
--- a/frontend/src/types/common/dashboard.ts
+++ b/frontend/src/types/common/dashboard.ts
@@ -30,4 +30,5 @@ export enum EAggregateOperator {
        RATE_AVG = 16,
        RATE_MAX = 17,
        RATE_MIN = 18,
+       NOOP = 19,
 }

@pranay01 pranay01 added this to the v0.8.2 milestone Jun 13, 2022
@pranshuchittora pranshuchittora added the update docs on SigNoz.io Adding this label will open an issue automatically on Signoz.io repo, once the PR get's merged label Jun 16, 2022
@srikanthccv
Copy link
Member

srikanthccv commented Jun 21, 2022

@pranshuchittora can you round of the start and end timestamps relative to step? For example end timestamp of 9m:15sec of end time to (9min or 10 min) if the step size is 60 sec? Otherwise points from 30s, 45, 60 do not fall into range causing slight dip at the ends of graph but the graph has 1 min interval data.

Comment on lines 46 to 47
'Average of values in timeframe', // SUM
'Sum of values in timeframe', // AVG
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is reverse

@pranshuchittora pranshuchittora marked this pull request as ready for review June 24, 2022 09:23
@ankitnayan ankitnayan changed the title WIP: Metrics Builder feat: Metrics Query Builder Jun 24, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jun 24, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 44 Code Smells

No Coverage information No Coverage information
3.7% 3.7% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
request-more-info update docs on SigNoz.io Adding this label will open an issue automatically on Signoz.io repo, once the PR get's merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants