-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Metrics Query Builder #1166
feat: Metrics Query Builder #1166
Conversation
We would appreciate it if you could provide us with more info about this issue/pr! |
feat: tag key selection feat: metrics builder
6643a5c
to
789a740
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
@pranshuchittora add this patch. Show tag values as they come for the reasons discussed here. diff --git a/frontend/src/container/NewWidget/LeftContainer/QuerySection/QueryBuilder/queryBuilder/MetricTagKeyFilter/utils.ts b/frontend/src/container/NewWidget/LeftContainer/QuerySection/QueryBuilder/queryBuilder/MetricTagKeyFilter/utils.ts
index 1ea5bfad..d50c6d64 100644
--- a/frontend/src/container/NewWidget/LeftContainer/QuerySection/QueryBuilder/queryBuilder/MetricTagKeyFilter/utils.ts
+++ b/frontend/src/container/NewWidget/LeftContainer/QuerySection/QueryBuilder/queryBuilder/MetricTagKeyFilter/utils.ts
@@ -34,7 +34,7 @@ export const GetTagValues = async (
if (!payload || !payload?.data) {
return [];
}
- return payload.data.filter(Boolean).map((tagValue: string) => ({
+ return payload.data.map((tagValue: string) => ({
label: tagValue,
value: tagValue,
}));
diff --git a/frontend/src/types/common/dashboard.ts b/frontend/src/types/common/dashboard.ts
index 13e45d45..45ced7b5 100644
--- a/frontend/src/types/common/dashboard.ts
+++ b/frontend/src/types/common/dashboard.ts
@@ -30,4 +30,5 @@ export enum EAggregateOperator {
RATE_AVG = 16,
RATE_MAX = 17,
RATE_MIN = 18,
+ NOOP = 19,
} |
…nshuchittora/signoz into pranshuchittora/feat/metrics-builder
@pranshuchittora can you round of the start and end timestamps relative to step? For example end timestamp of 9m:15sec of end time to (9min or 10 min) if the step size is 60 sec? Otherwise points from 30s, 45, 60 do not fall into range causing slight dip at the ends of graph but the graph has 1 min interval data. |
'Average of values in timeframe', // SUM | ||
'Sum of values in timeframe', // AVG |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is reverse
SonarCloud Quality Gate failed. 1 Bug No Coverage information |
No description provided.