Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support printing threshold in alert summary and description #1827

Merged
merged 10 commits into from
Feb 10, 2023
Merged

feat: support printing threshold in alert summary and description #1827

merged 10 commits into from
Feb 10, 2023

Conversation

mindhash
Copy link
Contributor

@mindhash mindhash commented Dec 7, 2022 •
edited by srikanthccv
Loading

This PR introduces following changes:

  • users can now refer to {{$threshold}} to print threshold (set in the alert) in the slack message
  • the default description is more clear on why the alert has been raised and prints the current observed value
  • for each alert, we append summary with observed and threshold value (similar to test alert notification)

Fixes #1771

@makeavish makeavish linked an issue Dec 7, 2022 that may be closed by this pull request
[Alerts] The alert message in slack does not show the calculated value #1771
Closed
srikanthccv
srikanthccv previously approved these changes Dec 26, 2022
View reviewed changes
Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one point about the description, but otherwise, this LGTM.

frontend/src/container/CreateAlertRule/defaults.ts Outdated Show resolved Hide resolved
palashgdev
palashgdev previously approved these changes Dec 26, 2022
View reviewed changes
@mindhash mindhash dismissed stale reviews from palashgdev and srikanthccv via d5264ac February 10, 2023 12:30
@sonarcloud
Copy link

sonarcloud bot commented Feb 10, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
4.1% 4.1% Duplication

@palashgdev palashgdev merged commit 8ab527b into SigNoz:develop Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranay01 pranay01 pranay01 left review comments

@palashgdev palashgdev palashgdev approved these changes

@srikanthccv srikanthccv srikanthccv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Alerts] The alert message in slack does not show the calculated value
5 participants
@mindhash @pranay01 @srikanthccv @palashgdev @makeavish