Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use rpc method and responseStatusCode #1971

Merged
merged 3 commits into from
Jan 4, 2023

Conversation

makeavish
Copy link
Member

No description provided.

@request-info
Copy link

request-info bot commented Jan 3, 2023

We would appreciate it if you could provide us with more info about this issue/pr!

@github-actions github-actions bot added the bug Something isn't working label Jan 3, 2023
@makeavish makeavish removed bug Something isn't working request-more-info labels Jan 3, 2023
@makeavish makeavish added this to the v0.13.1 milestone Jan 3, 2023
@makeavish makeavish marked this pull request as ready for review January 3, 2023 14:08
@ankitnayan ankitnayan removed their request for review January 3, 2023 17:36
@ankitnayan
Copy link
Collaborator

@makeavish please make sure the left menu filters in the trace-filter page and the tag filtering at the top are not using old columns.

@github-actions github-actions bot added bug Something isn't working codeball:needs-careful-review Codeball labels Jan 3, 2023
@makeavish
Copy link
Member Author

@ankitnayan This PR only updates getFilteredSpans API and doesn't affect any other API.
Deprecation of old columns will be taken up separately: #1967

@ankitnayan
Copy link
Collaborator

@ankitnayan This PR only updates getFilteredSpans API and doesn't affect any other API. Deprecation of old columns will be taken up separately: #1967

I wanted you to check if the other apis (getFilters and getAggregate) also need to be updated to use new columns and that they should not be using deprecated column anymore.

@makeavish
Copy link
Member Author

@ankitnayan Already checked that, only httpCode is being used in other APIs.
So it's causing some duplicacy as we already cover httpCode in responseStatusCode but it doesn't cause any bugs. So can be removed later.

@ankitnayan
Copy link
Collaborator

@ankitnayan Already checked that, only httpCode is being used in other APIs. So it's causing some duplicacy as we already cover httpCode in responseStatusCode but it doesn't cause any bugs. So can be removed later.

okay...please create an issue for that...bugs might surface later

@makeavish
Copy link
Member Author

makeavish commented Jan 4, 2023

Yes this issue was created for this objective: #1967

@ankitnayan Already checked that, only httpCode is being used in other APIs. So it's causing some duplicacy as we already cover httpCode in responseStatusCode but it doesn't cause any bugs. So can be removed later.

okay...please create an issue for that...bugs might surface later

@sonarcloud
Copy link

sonarcloud bot commented Jan 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ankitnayan ankitnayan merged commit 835251b into develop Jan 4, 2023
@ankitnayan ankitnayan deleted the fix/grpc-method-trace-table branch January 4, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working codeball:needs-careful-review Codeball
Projects
None yet
4 participants