Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add signoz.collector.id to spanmetrics dimensions #2001

Merged
merged 6 commits into from
Jan 10, 2023
Merged

fix: add signoz.collector.id to spanmetrics dimensions #2001

merged 6 commits into from
Jan 10, 2023

Conversation

srikanthccv
Copy link
Member

@srikanthccv srikanthccv commented Jan 7, 2023 •
edited
Loading

@github-actions
Copy link

github-actions bot commented Jan 7, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the bug Something isn't working label Jan 7, 2023
@srikanthccv srikanthccv changed the title fix: add service.instance.id to spanmetrics dimensions fix: add signoz.collector.id to spanmetrics dimensions Jan 9, 2023
@github-actions
Copy link

github-actions bot commented Jan 9, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
@github-actions
Copy link

github-actions bot commented Jan 9, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link

github-actions bot commented Jan 9, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@srikanthccv srikanthccv marked this pull request as ready for review January 10, 2023 06:21
@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@sonarcloud
Copy link

sonarcloud bot commented Jan 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@prashant-shahi prashant-shahi merged commit b675c3c into develop Jan 10, 2023
@srikanthccv srikanthccv deleted the spanmetrics-attrs branch January 10, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitnayan ankitnayan ankitnayan approved these changes

@prashant-shahi prashant-shahi prashant-shahi approved these changes

Assignees
No one assigned
Labels
bug Something isn't working codeball:needs-careful-review Codeball
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srikanthccv @prashant-shahi @ankitnayan