-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: antd is updated from v4 to v5 #2012
Conversation
@palashgdev the numbers in trace detail page are still black |
@palashgdev the toast message styling is changed |
@palashgdev bars on left menu incorrect styling in light mode |
I think I like the rounded toast styles more. but yes, color should be same as earlier @palashgdev @ankitnayan |
this and trace details issue is fixed though this was fixed in the prev pr so i got confused with me... thanks now it is fixed |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
in v5 support the dark background is dropped and changes in the config provider is also dropped in new version https://ant.design/components/config-provider#why-cant-configprovider-props-like-prefixcls-and-theme-affect-reactnode-inside-messageinfo-notificationopen-modalconfirm |
ok..let's create an issue to address this later |
Close https://github.com/SigNoz/engineering-pod/issues/906