Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: antd is updated from v4 to v5 #2012

Merged
merged 29 commits into from
Jan 11, 2023
Merged

feat: antd is updated from v4 to v5 #2012

merged 29 commits into from
Jan 11, 2023

Conversation

palashgdev
Copy link
Contributor

@palashgdev
Copy link
Contributor Author

darkMode: Screenshot 2023-01-10 at 11 25 07 PM

lightMode: Screenshot 2023-01-10 at 11 26 32 PM

@ankitnayan
Copy link
Collaborator

@palashgdev the numbers in trace detail page are still black

Screenshot 2023-01-11 at 12 57 27 PM

@ankitnayan
Copy link
Collaborator

@palashgdev the toast message styling is changed

Screenshot 2023-01-11 at 1 04 10 PM
Screenshot 2023-01-11 at 1 04 45 PM

@ankitnayan
Copy link
Collaborator

@palashgdev bars on left menu incorrect styling in light mode

Screenshot 2023-01-11 at 1 06 35 PM

@pranay01
Copy link
Collaborator

I think I like the rounded toast styles more. but yes, color should be same as earlier @palashgdev @ankitnayan

@ankitnayan
Copy link
Collaborator

In logs detail view, Action is multiline

Screenshot 2023-01-11 at 1 10 31 PM

@palashgdev
Copy link
Contributor Author

@palashgdev bars on left menu incorrect styling in light mode

Screenshot 2023-01-11 at 1 06 35 PM

this and trace details issue is fixed though this was fixed in the prev pr so i got confused with me... thanks now it is fixed

@palashgdev
Copy link
Contributor Author

In logs detail view, Action is multiline

Screenshot 2023-01-11 at 1 10 31 PM

fixed but found in stage also

@sonarcloud
Copy link

sonarcloud bot commented Jan 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@palashgdev
Copy link
Contributor Author

@palashgdev the toast message styling is changed

Screenshot 2023-01-11 at 1 04 10 PM Screenshot 2023-01-11 at 1 04 45 PM

in v5 support the dark background is dropped and changes in the config provider is also dropped in new version https://ant.design/components/config-provider#why-cant-configprovider-props-like-prefixcls-and-theme-affect-reactnode-inside-messageinfo-notificationopen-modalconfirm

@ankitnayan
Copy link
Collaborator

in v5 support the dark background is dropped and changes in the config provider is also dropped in new version https://ant.design/components/config-provider#why-cant-configprovider-props-like-prefixcls-and-theme-affect-reactnode-inside-messageinfo-notificationopen-modalconfirm

ok..let's create an issue to address this later

@ankitnayan ankitnayan merged commit 2f5908a into SigNoz:develop Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants