feat: Added Resizable Wrapper for Ant Design Table #2014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome to the SigNoz community! Thank you for your first pull request and making this project better. 🤗 |
palashgdev
suggested changes
Jan 11, 2023
techchintan
force-pushed
the
fix/issue-1792
branch
from
91692e4
to
cb96aa3
Compare
…o fix/issue-1792
…o fix/issue-1792
techchintan
force-pushed
the
fix/issue-1792
branch
2 times, most recently
from
780d2d1
to
678533b
Compare
techchintan
force-pushed
the
fix/issue-1792
branch
from
678533b
to
c142177
Compare
palashgdev
suggested changes
Jan 16, 2023
frontend/src/components/ResizeTableWrapper/ResizeTableWrapper.tsx
Outdated
Show resolved
Hide resolved
techchintan
force-pushed
the
fix/issue-1792
branch
from
e4db598
to
0384fd2
Compare
techchintan
force-pushed
the
fix/issue-1792
branch
from
2500679
to
98fca39
Compare
|
It overall looks good. But there is high sensitivity on cursor drag. If we can have a quick fix for that then it would be awesome otherwise LGTM. Sharing a loom for the same |
|
Kudos, SonarCloud Quality Gate passed!
|
palashgdev
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #1792