Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FE: added more eslint rule #2090

Merged
merged 6 commits into from
Jan 24, 2023
Merged

FE: added more eslint rule #2090

merged 6 commits into from
Jan 24, 2023

Conversation

palashgdev
Copy link
Contributor

Part of #409

@palashgdev palashgdev self-assigned this Jan 22, 2023
srikanthccv
srikanthccv reviewed Jan 24, 2023
View reviewed changes
Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were these auto formatted changes or hand made changes?

@palashgdev
Copy link
Contributor Author

palashgdev commented Jan 24, 2023 •
edited
Loading

No this are from yarn lint:fix

@sonarcloud
Copy link

sonarcloud bot commented Jan 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@palashgdev palashgdev merged commit e62e541 into SigNoz:develop Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srikanthccv srikanthccv srikanthccv approved these changes

@ankitnayan ankitnayan Awaiting requested review from ankitnayan

@makeavish makeavish Awaiting requested review from makeavish

Assignees

@palashgdev palashgdev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@palashgdev @srikanthccv