Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(frontend): 🔧 support ARM and copy yarnrc in Dockerfile #2119

Merged
merged 2 commits into from
Jan 25, 2023

Conversation

prashant-shahi
Copy link
Member

@prashant-shahi prashant-shahi commented Jan 25, 2023

  • Support ARM for SigNoz Frontend - this fixes issues with Mac M1/M2 chip
  • Copy yarnrc file prior to yarn install in Dockerfile - this fixes issues seen in Staging env

Signed-off-by: Prashant Shahi prashant@signoz.io

Signed-off-by: Prashant Shahi <prashant@signoz.io>
@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the codeball:approved Codeball label Jan 25, 2023
github-actions[bot]
github-actions bot previously approved these changes Jan 25, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeball: LGTM! 👍

confidence: 0.98 | [dashboard]

@palashgdev palashgdev closed this Jan 25, 2023
@palashgdev palashgdev reopened this Jan 25, 2023
@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot dismissed their stale review January 25, 2023 14:26

confidence: 0.84 | [dashboard]

@sonarcloud
Copy link

sonarcloud bot commented Jan 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pranay01 pranay01 merged commit 13f9922 into develop Jan 25, 2023
@srikanthccv srikanthccv deleted the prashant/frontend-fixes branch January 25, 2023 14:29
@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

prashant-shahi added a commit that referenced this pull request Jan 26, 2023
Signed-off-by: Prashant Shahi <prashant@signoz.io>

Signed-off-by: Prashant Shahi <prashant@signoz.io>
Co-authored-by: Palash Gupta <palashgdev@gmail.com>
(cherry picked from commit 13f9922)
Signed-off-by: Prashant Shahi <prashant@signoz.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants