Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: solved re-render issue when input fields were edited #2149

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

mindhash
Copy link
Contributor

Solves side-effect introduced by #2130

The PR solves exactly the same problem as in original PR but in a slightly different way. Instead of refreshing the query panel every time the query changes, here we limit the refresh (re-render) of query-panel only when delete icon is clicked.

Original Problem:

Steps to reproduce:

In log query search panel, add 3 search fields: id IN 'id', stream IN 's', container_id in 'c'
remove the second search field (stream IN 's')
Expected: the second field (stream in 's') goes away, and you should see the remaining two search fields in the query panel.

Actual: the second search field goes away but condition and values from this field are being stamped on the third field.
here is what you see in the panel:

id in 'id'
container_id in 's'
Notice, how the search value of stream 's' got copied over to container id

@sonarcloud
Copy link

sonarcloud bot commented Jan 31, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
4.2% 4.2% Duplication

@palashgdev palashgdev merged commit faaf0a6 into SigNoz:develop Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants