fix: solved re-render issue when input fields were edited #2149
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves side-effect introduced by #2130
The PR solves exactly the same problem as in original PR but in a slightly different way. Instead of refreshing the query panel every time the query changes, here we limit the refresh (re-render) of query-panel only when delete icon is clicked.
Original Problem:
Steps to reproduce:
In log query search panel, add 3 search fields: id IN 'id', stream IN 's', container_id in 'c'
remove the second search field (stream IN 's')
Expected: the second field (stream in 's') goes away, and you should see the remaining two search fields in the query panel.
Actual: the second search field goes away but condition and values from this field are being stamped on the third field.
here is what you see in the panel:
id in 'id'
container_id in 's'
Notice, how the search value of stream 's' got copied over to container id