Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: it has been fixed of difficult to click on metrics graph points #2207

Merged
merged 12 commits into from
Feb 15, 2023
Merged

fix: it has been fixed of difficult to click on metrics graph points #2207

merged 12 commits into from
Feb 15, 2023

Conversation

KolesnikAntony
Copy link
Contributor

Close #2194
-it has been fixed of difficult to click on metrics graph points;
-DataSets of chart has been refactored and minimized;

@welcome
Copy link

welcome bot commented Feb 8, 2023

Welcome to the SigNoz community! Thank you for your first pull request and making this project better. 🤗

@github-actions github-actions bot added bug Something isn't working codeball:needs-careful-review Codeball labels Feb 8, 2023
@palashgdev
Copy link
Contributor

@KolesnikAntony can you please verify increasing or reducing the radius is not solving the issue

@KolesnikAntony
Copy link
Contributor Author

It has been added condition which gives us posibilities to compare start and end position of mouseDown and mouseUp. So as DND works on mouseDown and MouseUp events we were getting the reload of timestamps by click or double click.

@palashgdev
Copy link
Contributor

It has been added condition which gives us posibilities to compare start and end position of mouseDown and mouseUp. So as DND works on mouseDown and MouseUp events we were getting the reload of timestamps by click or double click.

ok this sounds good to me

@palashgdev palashgdev self-requested a review February 15, 2023 05:10
@sonarcloud
Copy link

sonarcloud bot commented Feb 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@palashgdev palashgdev merged commit 0507696 into develop Feb 15, 2023
@palashgdev palashgdev deleted the bug/issue-2194 branch February 15, 2023 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palashgdev palashgdev palashgdev approved these changes

@makeavish makeavish Awaiting requested review from makeavish

Assignees

@KolesnikAntony KolesnikAntony

Labels
bug Something isn't working codeball:needs-careful-review Codeball
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Difficult to click on metrics graph points to view traces
2 participants
@KolesnikAntony @palashgdev