Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dark mode is fixed in alert create page #2220

Merged
merged 3 commits into from
Feb 10, 2023
Merged

fix: dark mode is fixed in alert create page #2220

merged 3 commits into from
Feb 10, 2023

Conversation

palashgdev
Copy link
Contributor

Close #2217

mindhash
mindhash approved these changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@mindhash mindhash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@palashgdev palashgdev self-assigned this Feb 10, 2023
@sonarcloud
Copy link

sonarcloud bot commented Feb 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ankitnayan ankitnayan merged commit 9a184f5 into SigNoz:develop Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mindhash mindhash mindhash approved these changes

@ankitnayan ankitnayan Awaiting requested review from ankitnayan

Assignees

@palashgdev palashgdev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New alert channel UI has issues
3 participants
@palashgdev @mindhash @ankitnayan