fix: operator should be IN for top level operations #2304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We would appreciate it if you could provide us with more info about this issue/pr! |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Check the op/s difference in the staging app for the service list page vs the overview page. |
palashgdev
approved these changes
Feb 22, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I initially suspected something about the sharding here, but that was reverted here #1847 already, and indeed that wasn't the issue.
The
MATCHoperator works on a single value. When migrated from the PromQL to Query builder, the operation used was incorrect. Since the PromQL doesn't support theINwe used the~=a|b|cwhich is a regex match and that same meaning is copied over, but the values were not concatenated with re2 syntax like they were for PromQL which behaves randomly based on the first operation received from the/top_level_operationsAPI which doesn't guarantee any order.Fixes #2305
Partially(or fully) address #2291