Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ability to clone a panel #2444

Merged
merged 5 commits into from
Jun 7, 2023
Merged

Conversation

gitstart
Copy link
Contributor

@gitstart gitstart commented Mar 13, 2023

Fixes #707

Demo

https://www.loom.com/share/0a19db7c24454924a7c875e9d901a6cf


This code was written and reviewed by GitStart Community. Growing future engineers, one PR at a time.

@palashgdev
Copy link
Contributor

palashgdev commented Mar 14, 2023

Hello, @gitstart

thank you raising the PR.

rather than providing a clone widget option on the widget page

would it be feasible to add option to the widget header(src/container/GridGraphLayout/WidgetHeader)? (only visible for editor and admin permission)

PS: You can use the menu's Copy icon in the menu

@gitstart
Copy link
Contributor Author

Hello, @gitstart

thank you raising the PR.

rather than providing a clone widget option on the widget page

would it be feasible to add option to the widget header(src/container/GridGraphLayout/WidgetHeader)? (only visible for editor and admin permission)

PS: You can use the menu's Copy icon in the menu

Thank you for the review @palashgdev. We are working on it

@gitstart
Copy link
Contributor Author

Hi @palashgdev, we have made the required changes. Please review

@sonarcloud
Copy link

sonarcloud bot commented Mar 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.1% 1.1% Duplication

@CLAassistant
Copy link

CLAassistant commented Apr 21, 2023

CLA assistant check
All committers have signed the CLA.

@palashgdev
Copy link
Contributor

@gitstart can you please check the number of changes seems like there is some issue

Co-authored-by: Nitesh Singh <nitesh.singh@gitstart.dev>
@gitstart
Copy link
Contributor Author

@gitstart can you please check the number of changes seems like there is some issue

Sorry about that, it's fixed now @palashgdev

@srikanthccv
Copy link
Member

I commented on an earlier PR, which appears to be doing the same #2646. Are these two same?

@palashgdev
Copy link
Contributor

I commented on an earlier PR, which appears to be doing the same #2646. Are these two same?

was not aware of #2646 @gitstart can you please confirm?

@gitstart
Copy link
Contributor Author

gitstart commented Jun 5, 2023

I commented on an earlier PR, which appears to be doing the same #2646. Are these two same?

was not aware of #2646 @gitstart can you please confirm?

No, these are not the same. #2646 is for cloning an Alert and this PR is for cloning a Panel. cc: @palashgdev @srikanthccv

@palashgdev palashgdev merged commit 826cbe0 into SigNoz:develop Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to Clone a Panel
6 participants